Bug 2093503: Assisted service POD keeps crashing after a bare metal host is created

[eranco74]

Initialize the PreprovisioningImage VersionsHandler and OcRelease

• Should this PR be tested by the reviewer? no
• Is this PR relying on CI for an e2e test run? For regression
• Should this PR be tested in a specific environment? dev scripts
• Any logs, screenshots, etc that can help with the review process? no

-->

List all the issues related to this PR

https://bugzilla.redhat.com/show_bug.cgi?id=2093503

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

Testing manually - WIP

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Assignees

/cc @filanov
/cc @tsorya

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests) - UT initialize the struct properly 🤦

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci]

@eranco74: This pull request references Bugzilla bug 2093503, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (rhacm-2.6) matches configured target release for branch (rhacm-2.6)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @chadcrum

In response to this:

Bug 2093503: Assisted service POD keeps crashing after a bare metal host is created

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [eranco74,filanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #3897 (400e430) into master (0bcad46) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3897      +/-   ##
==========================================
+ Coverage   66.28%   66.29%   +0.01%     
==========================================
  Files         179      179              
  Lines       24985    24985              
==========================================
+ Hits        16561    16565       +4     
+ Misses       6884     6882       -2     
+ Partials     1540     1538       -2     

Impacted Files	Coverage Δ
...ler/controllers/preprovisioningimage_controller.go	80.54% <100.00%> (ø)
internal/cluster/validations/validations.go	44.56% <0.00%> (+0.74%)	⬆️
internal/oc/release.go	73.64% <0.00%> (+1.35%)	⬆️

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD 0bcad46 and 8 for PR HEAD bf58633 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD 0bcad46 and 7 for PR HEAD bf58633 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0bcad46 and 6 for PR HEAD bf58633 in total

[tsorya]

/lgtm

[openshift-ci]

@eranco74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted-capi	400e430	link	false	/test edge-e2e-metal-assisted-capi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@eranco74: All pull requests linked via external trackers have merged:

• openshift/assisted-service#3897

Bugzilla bug 2093503 has been moved to the MODIFIED state.

In response to this:

Bug 2093503: Assisted service POD keeps crashing after a bare metal host is created

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.