MGMT-10656: Enable multipathd by default in live ISO

[avishayt]

To better support FC multipath, this commit configures the ignition
config to create multipath.conf and enable multipathd by default in the
live ISO.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Assignees

/cc @javipolo
/cc @tsorya

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[avishayt]

/hold

[codecov]

Codecov Report

Merging #3951 (59afc11) into master (325e643) will increase coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3951      +/-   ##
==========================================
+ Coverage   66.23%   66.70%   +0.47%     
==========================================
  Files         179      179              
  Lines       25042    25297     +255     
==========================================
+ Hits        16586    16874     +288     
+ Misses       6911     6891      -20     
+ Partials     1545     1532      -13     

Impacted Files	Coverage Δ
internal/ignition/ignition.go	56.92% <ø> (ø)
internal/oc/release.go	73.64% <0.00%> (+1.35%)	⬆️
internal/host/hostutil/host_utils.go	32.17% <0.00%> (+3.87%)	⬆️
internal/host/hostcommands/install_cmd.go	86.29% <0.00%> (+5.32%)	⬆️
internal/host/validator.go	84.88% <0.00%> (+6.54%)	⬆️

[avishayt]

/unhold

[tsorya]

/lgtm
I assume it should work for all rhcos versions right?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, javipolo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avishayt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[romfreiman]

if user still set it via ignition, will it work?

[avishayt]

/hold

[avishayt]

/unhold

[avishayt]

if user still set it via ignition, will it work?

Yes, I tested doing an ignition config override that changes the multipath.conf file, and it gets the contents of the override instead of what's in this PR

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD c37d554 and 8 for PR HEAD 59afc11 in total

[openshift-ci]

@avishayt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.