Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow #4090

eranco74 · 2022-07-07T11:00:16Z

If the converged flow is enabled BMAC should detach the BMH only once it's provisioned

Should this PR be tested by the reviewer? no
Is this PR relying on CI for an e2e test run? no
Should this PR be tested in a specific environment? no
Any logs, screenshots, etc that can help with the review process? no

-->

List all the issues related to this PR

https://bugzilla.redhat.com/show_bug.cgi?id=2104117

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Assignees

/cc @avishayt
/cc @flaper87

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
Reviewers have been listed
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci · 2022-07-07T11:00:29Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2022-07-07T11:00:49Z

@eranco74: This pull request references Bugzilla bug 2104117, which is invalid:

expected the bug to target the "rhacm-2.6" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eranco74 · 2022-07-07T16:13:11Z

/test ?

eranco74 · 2022-07-07T16:13:40Z

/bugzilla refresh

openshift-ci · 2022-07-07T16:14:03Z

@eranco74: The following commands are available to trigger required jobs:

/test edge-ci-index
/test edge-e2e-ai-operator-ztp-converged
/test edge-e2e-metal-assisted
/test edge-e2e-metal-assisted-operator-ztp
/test edge-e2e-metal-assisted-operator-ztp-sno-day2-workers
/test edge-e2e-metal-assisted-operator-ztp-sno-day2-workers-latbnd
/test edge-images
/test edge-lint
/test edge-subsystem-aws
/test edge-subsystem-kubeapi-aws
/test edge-unit-test
/test edge-verify-generated-code
/test images
/test mce-images

The following commands are available to trigger optional jobs:

/test edge-e2e-ai-operator-ztp-ipv4v6-3masters-ocp-410
/test edge-e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49
/test edge-e2e-ai-operator-ztp-ipv4v6-sno-ocp-410
/test edge-e2e-ai-operator-ztp-ipv4v6-sno-ocp-49
/test edge-e2e-metal-assisted-4-10
/test edge-e2e-metal-assisted-4-11
/test edge-e2e-metal-assisted-4-8
/test edge-e2e-metal-assisted-4-9
/test edge-e2e-metal-assisted-capi
/test edge-e2e-metal-assisted-cnv
/test edge-e2e-metal-assisted-day2
/test edge-e2e-metal-assisted-day2-single-node
/test edge-e2e-metal-assisted-ipv4v6
/test edge-e2e-metal-assisted-ipv6
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node
/test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
/test edge-e2e-metal-assisted-kube-api-net-suite
/test edge-e2e-metal-assisted-none
/test edge-e2e-metal-assisted-ocs
/test edge-e2e-metal-assisted-odf
/test edge-e2e-metal-assisted-onprem
/test edge-e2e-metal-assisted-operator-capi
/test edge-e2e-metal-assisted-operator-disconnected
/test edge-e2e-metal-assisted-operator-ztp-multinode-spoke
/test edge-e2e-metal-assisted-single-node
/test edge-e2e-metal-assisted-static-ip-suite
/test edge-e2e-metal-assisted-tang
/test edge-e2e-metal-assisted-tpmv2
/test edge-push-pr-image
/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-edge-ci-index
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-capi
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-operator-ztp
pull-ci-openshift-assisted-service-master-edge-images
pull-ci-openshift-assisted-service-master-edge-lint
pull-ci-openshift-assisted-service-master-edge-subsystem-aws
pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
pull-ci-openshift-assisted-service-master-edge-unit-test
pull-ci-openshift-assisted-service-master-edge-verify-generated-code
pull-ci-openshift-assisted-service-master-images
pull-ci-openshift-assisted-service-master-mce-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-07-07T16:14:24Z

@eranco74: This pull request references Bugzilla bug 2104117, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (rhacm-2.6) matches configured target release for branch (rhacm-2.6)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @chadcrum

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eranco74 · 2022-07-07T16:14:46Z

/test edge-e2e-ai-operator-ztp-converged
/hold

codecov · 2022-07-07T16:37:46Z

Codecov Report

Merging #4090 (d60b550) into master (571ce53) will decrease coverage by 0.86%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##           master    #4090      +/-   ##
==========================================
- Coverage   66.12%   65.25%   -0.87%     
==========================================
  Files         184      186       +2     
  Lines       25851    26342     +491     
==========================================
+ Hits        17093    17190      +97     
- Misses       7191     7571     +380     
- Partials     1567     1581      +14

Impacted Files	Coverage Δ
...nal/controller/controllers/bmh_agent_controller.go	`67.06% <81.48%> (+0.54%)`	⬆️
internal/host/hostutil/host_utils.go	`24.47% <0.00%> (-1.85%)`	⬇️
internal/network/utils.go	`26.81% <0.00%> (-1.26%)`	⬇️
internal/host/hostutil/test_utils.go	`10.19% <0.00%> (-0.76%)`	⬇️
internal/cluster/validations/validations.go	`43.82% <0.00%> (-0.75%)`	⬇️
internal/host/host.go	`74.01% <0.00%> (-0.49%)`	⬇️
internal/host/validator.go	`77.96% <0.00%> (-0.47%)`	⬇️
internal/bminventory/inventory.go	`69.80% <0.00%> (-0.12%)`	⬇️
internal/host/statemachine.go	`100.00% <0.00%> (ø)`
internal/provider/ovirt/ignition.go	`0.00% <0.00%> (ø)`
... and 11 more

internal/controller/controllers/bmh_agent_controller.go

…a the converged workflow If the converged flow enabled BMAC should detach the BMH only once it's provisioned

openshift-ci · 2022-07-10T07:07:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [eranco74,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-07-10T09:37:39Z

@eranco74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted-capi	`d60b550`	link	false	`/test edge-e2e-metal-assisted-capi`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

eranco74 · 2022-07-10T09:43:22Z

/unhold

openshift-ci · 2022-07-10T09:44:57Z

@eranco74: All pull requests linked via external trackers have merged:

openshift/assisted-service#4090

Bugzilla bug 2104117 has been moved to the MODIFIED state.

In response to this:

Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…a the converged workflow (openshift#4090) If the converged flow enabled BMAC should detach the BMH only once it's provisioned

openshift-ci bot requested review from avishayt and flaper87 July 7, 2022 11:00

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jul 7, 2022

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 7, 2022

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2022

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 7, 2022

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 7, 2022

eranco74 marked this pull request as ready for review July 7, 2022 16:14

openshift-ci bot requested a review from chadcrum July 7, 2022 16:14

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 7, 2022

eranco74 force-pushed the bug-2104117 branch from 45b3170 to 3a832e9 Compare July 7, 2022 18:46

osherdp suggested changes Jul 10, 2022

View reviewed changes

internal/controller/controllers/bmh_agent_controller.go Outdated Show resolved Hide resolved

openshift-ci bot assigned osherdp Jul 10, 2022

eranco74 force-pushed the bug-2104117 branch from 3a832e9 to 104f108 Compare July 10, 2022 06:58

Bug 2104117: BMH stuck “available” after changing a BIOS attribute vi…

d60b550

…a the converged workflow If the converged flow enabled BMAC should detach the BMH only once it's provisioned

eranco74 force-pushed the bug-2104117 branch from 104f108 to d60b550 Compare July 10, 2022 07:01

eranco74 requested a review from osherdp July 10, 2022 07:02

osherdp approved these changes Jul 10, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2022

openshift-ci bot merged commit 9b5bb30 into openshift:master Jul 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow #4090

Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow #4090

eranco74 commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

eranco74 commented Jul 7, 2022

eranco74 commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

eranco74 commented Jul 7, 2022

codecov bot commented Jul 7, 2022 •

edited

openshift-ci bot commented Jul 10, 2022

openshift-ci bot commented Jul 10, 2022

eranco74 commented Jul 10, 2022

openshift-ci bot commented Jul 10, 2022

Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow #4090

Bug 2104117: BMH stuck “available” after changing a BIOS attribute via the converged workflow #4090

Conversation

eranco74 commented Jul 7, 2022

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Assignees

Checklist

Reviewers Checklist

openshift-ci bot commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

eranco74 commented Jul 7, 2022

eranco74 commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

openshift-ci bot commented Jul 7, 2022

eranco74 commented Jul 7, 2022

codecov bot commented Jul 7, 2022 • edited

Codecov Report

openshift-ci bot commented Jul 10, 2022

openshift-ci bot commented Jul 10, 2022

eranco74 commented Jul 10, 2022

openshift-ci bot commented Jul 10, 2022

codecov bot commented Jul 7, 2022 •

edited