Bug 2099929: Detach BMH using dedicated function

[mkowalski]

This commit changes the way we add detached annotation to the BMH.
Instead of doing it always manually, we now call a helper function
responsible for logging this action and taking care of handling empty
annotations.

Contributes-to: Bug-2099929

/cc @flaper87
/cc @omertuc

[openshift-ci]

@mkowalski: This pull request references Bugzilla bug 2099929, which is invalid:

• expected the bug to target the "rhacm-2.6" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2099929: Detach BMH using dedicated function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mkowalski]

/bugzilla refresh

[openshift-ci]

@mkowalski: This pull request references Bugzilla bug 2099929, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (rhacm-2.6) matches configured target release for branch (rhacm-2.6)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @chadcrum

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #4202 (17c5fa7) into master (de25270) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4202      +/-   ##
==========================================
- Coverage   65.50%   65.50%   -0.01%     
==========================================
  Files         189      189              
  Lines       26392    26390       -2     
==========================================
- Hits        17289    17287       -2     
  Misses       7499     7499              
  Partials     1604     1604              

Impacted Files	Coverage Δ
...nal/controller/controllers/bmh_agent_controller.go	66.80% <100.00%> (+0.17%)	⬆️
internal/oc/release.go	70.51% <0.00%> (-1.29%)	⬇️

[omertuc]

/cc @eranco74

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD de25270 and 8 for PR HEAD 17c5fa7 in total

[openshift-ci]

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted-capi	17c5fa7	link	false	/test edge-e2e-metal-assisted-capi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@mkowalski: All pull requests linked via external trackers have merged:

• openshift/assisted-service#4202

Bugzilla bug 2099929 has been moved to the MODIFIED state.

In response to this:

Bug 2099929: Detach BMH using dedicated function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.