Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.6] Bug 2112803: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest #4208

Conversation

eliorerz
Copy link
Contributor

/cc @osherdp

@openshift-ci openshift-ci bot requested a review from osherdp July 31, 2022 12:30
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2022

@eliorerz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

MGMT-11411: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2022
Makefile Outdated Show resolved Hide resolved
@eliorerz eliorerz force-pushed the MGMT-11411-Fix_image_tags_in_operator's_CSV branch from ba0bad5 to 74756f1 Compare July 31, 2022 12:34
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #4208 (5f034fc) into release-ocm-2.6 (6751daf) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.6    #4208      +/-   ##
===================================================
- Coverage            65.57%   65.56%   -0.01%     
===================================================
  Files                  189      189              
  Lines                26484    26484              
===================================================
- Hits                 17367    17365       -2     
- Misses                7514     7515       +1     
- Partials              1603     1604       +1     
Impacted Files Coverage Δ
internal/oc/release.go 70.51% <0.00%> (-1.29%) ⬇️

…correctly point to :ocm-2.6 instead of :latest
@eliorerz eliorerz force-pushed the MGMT-11411-Fix_image_tags_in_operator's_CSV branch from 74756f1 to 5f034fc Compare July 31, 2022 13:06
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@eliorerz eliorerz changed the title MGMT-11411: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest [release-ocm-2.6] MGMT-11411: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest Jul 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2022

@eliorerz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-ocm-2.6] MGMT-11411: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eliorerz
Copy link
Contributor Author

/retest

@eliorerz
Copy link
Contributor Author

eliorerz commented Aug 1, 2022

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2022

@eliorerz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz eliorerz changed the title [release-ocm-2.6] MGMT-11411: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest [release-ocm-2.6] Bug 2112803: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest Aug 1, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2022

@eliorerz: This pull request references Bugzilla bug 2112803, which is invalid:

  • expected the bug to target the "rhacm-2.6" release, but it targets "---" instead
  • expected Bugzilla bug 2112803 to depend on a bug targeting a release in rhacm-2.7 and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-ocm-2.6] Bug 2112803: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz
Copy link
Contributor Author

eliorerz commented Aug 1, 2022

/bugzilla refresh

@openshift openshift deleted a comment from openshift-ci bot Aug 1, 2022
@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 1, 2022
@openshift openshift deleted a comment from openshift-ci bot Aug 1, 2022
@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2022

@eliorerz: This pull request references Bugzilla bug 2112803, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (rhacm-2.6) matches configured target release for branch (rhacm-2.6)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2112804 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2112804 targets the "rhacm-2.7" release, which is one of the valid target releases: rhacm-2.7
  • bug has dependents

Requesting review from QA contact:
/cc @chadcrum

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from chadcrum August 1, 2022 15:41
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 6751daf and 8 for PR HEAD 5f034fc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 6751daf and 7 for PR HEAD 5f034fc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6751daf and 6 for PR HEAD 5f034fc in total

@osherdp
Copy link
Contributor

osherdp commented Aug 4, 2022

/retest
capi should be fixed, disconnected might also be affected by some other change

@osherdp
Copy link
Contributor

osherdp commented Aug 4, 2022

/test e2e-ai-operator-ztp-disconnected

@osherdp
Copy link
Contributor

osherdp commented Aug 4, 2022

/retest

1 similar comment
@osherdp
Copy link
Contributor

osherdp commented Aug 4, 2022

/retest

@osherdp
Copy link
Contributor

osherdp commented Aug 4, 2022

Now that #4238 has been merged we should get a new result
/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 32b7568 and 5 for PR HEAD 5f034fc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 32b7568 and 4 for PR HEAD 5f034fc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 32b7568 and 3 for PR HEAD 5f034fc in total

@osherdp
Copy link
Contributor

osherdp commented Aug 5, 2022

It gets us past operator installation now, so let's merge it
/override ci/prow/e2e-ai-operator-ztp-disconnected

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/e2e-ai-operator-ztp-disconnected

In response to this:

It gets us past operator installation now, so let's merge it
/override ci/prow/e2e-ai-operator-ztp-disconnected

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@eliorerz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp-disconnected 5f034fc link true /test e2e-ai-operator-ztp-disconnected

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit e612c65 into openshift:release-ocm-2.6 Aug 5, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2022

@eliorerz: All pull requests linked via external trackers have merged:

Bugzilla bug 2112803 has been moved to the MODIFIED state.

In response to this:

[release-ocm-2.6] Bug 2112803: Fix image references for the release branch so that they correctly point to :ocm-2.6 instead of :latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz eliorerz deleted the MGMT-11411-Fix_image_tags_in_operator's_CSV branch August 7, 2022 07:18
flaper87 pushed a commit to flaper87/assisted-service that referenced this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants