Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: Do not merge - fixing broken CI jobs #4260

Closed
wants to merge 1 commit into from
Closed

NO-ISSUE: Do not merge - fixing broken CI jobs #4260

wants to merge 1 commit into from

Conversation

nmagnezi
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmagnezi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022 •
edited

Codecov Report

Merging #4260 (db8c2ea) into release-ocm-2.6 (e612c65) will increase coverage by 1.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.6    #4260      +/-   ##
===================================================
+ Coverage            65.56%   67.06%   +1.49%     
===================================================
  Files                  189      189              
  Lines                26484    27849    +1365     
===================================================
+ Hits                 17365    18676    +1311     
- Misses                7515     7539      +24     
- Partials              1604     1634      +30
Impacted Files Coverage Δ
internal/bminventory/inventory.go 77.97% <100.00%> (+8.64%) ⬆️
internal/oc/release.go 70.51% <0.00%> (-1.29%) ⬇️
internal/host/hostutil/test_utils.go 11.11% <0.00%> (+0.51%) ⬆️
internal/cluster/validations/validations.go 45.92% <0.00%> (+1.89%) ⬆️
...ost/hostcommands/api_vip_connectivity_check_cmd.go 79.03% <0.00%> (+2.94%) ⬆️
internal/host/hostutil/host_utils.go 31.51% <0.00%> (+7.03%) ⬆️

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi nmagnezi force-pushed the ocm-2.6_fix_ci branch 3 times, most recently from 7d5c6c2 to 87d35a4 Compare August 15, 2022 08:27
slaviered
slaviered reviewed Aug 15, 2022
View reviewed changes
deploy/operator/utils.sh Outdated Show resolved Hide resolved
@nmagnezi nmagnezi force-pushed the ocm-2.6_fix_ci branch 2 times, most recently from 4ca1745 to cae19db Compare August 15, 2022 11:52
@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@osherdp
Copy link
Contributor

osherdp commented Aug 16, 2022

/uncc

@openshift-ci openshift-ci bot removed the request for review from osherdp August 16, 2022 08:06
@nmagnezi
Copy link
Contributor Author

/uncc @jakub-dzon

@openshift-ci openshift-ci bot removed the request for review from jakub-dzon August 16, 2022 08:34
@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

9 similar comments
@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@openshift-ci openshift-ci bot added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Aug 21, 2022
@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

2 similar comments
@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@nmagnezi
Copy link
Contributor Author

/test e2e-ai-operator-ztp-disconnected

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

@nmagnezi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp-disconnected db8c2ea link true /test e2e-ai-operator-ztp-disconnected

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmagnezi
Copy link
Contributor Author

Filed https://issues.redhat.com/browse/OCPBUGS-511

@nmagnezi nmagnezi closed this Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaviered slaviered slaviered left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmagnezi @osherdp @slaviered