Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-11618: remove OCP 4.7 #4268

Merged
merged 1 commit into from Aug 16, 2022

Conversation

osherdp
Copy link
Contributor

@osherdp osherdp commented Aug 15, 2022

It has no usage in SaaS, it is almost EOL, and we're just wasting time with downloading its corresponding ISO image.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @gamli75
/cc @eliorerz

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #4268 (ad20704) into master (2343139) will not change coverage.
The diff coverage is n/a.

❗ Current head ad20704 differs from pull request most recent head 806bce8. Consider uploading reports for the commit 806bce8 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4268   +/-   ##
=======================================
  Coverage   66.11%   66.11%           
=======================================
  Files         189      189           
  Lines       26698    26698           
=======================================
  Hits        17651    17651           
  Misses       7440     7440           
  Partials     1607     1607           

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD ad20704 and 8 for PR HEAD 806bce8 in total

@osherdp
Copy link
Contributor Author

osherdp commented Aug 15, 2022

/override ci/prow/edge-e2e-metal-assisted-day2-single-node

@osherdp
Copy link
Contributor Author

osherdp commented Aug 15, 2022

/override ci/prow/edge-e2e-metal-assisted-ipv4v6

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2022

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/edge-e2e-metal-assisted-day2-single-node

In response to this:

/override ci/prow/edge-e2e-metal-assisted-day2-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2022

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/edge-e2e-metal-assisted-ipv4v6

In response to this:

/override ci/prow/edge-e2e-metal-assisted-ipv4v6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2022

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4274c3e into openshift:master Aug 16, 2022
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants