Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix command syntax for getting postgres size #4498

Merged
merged 1 commit into from Oct 14, 2022

Conversation

CrystalChun
Copy link
Contributor

The kubectl command was missing curly braces. The output would be: ".spec.resources.requests.storage", causing the rest of the script to error out.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested):
    • deployed subystem tests and make deploy-service-for-subsystem-test passed successfully.
    • Also added the following into tools/pvc_size_utils.py and ran $ python3 tools/pvc_size_utils.py to make sure the output was correct.
    if __name__ == "__main__":
        size = get_current_size_if_exist(target="local", namespace="assisted-installer", pvc_name="postgres-pv-claim")
        print(size)
    
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @omertuc @adriengentil

The kubectl command was missing curly braces. The output
would be: ".spec.resources.requests.storage", causing the
rest of the script to error out.
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #4498 (e31b2e9) into master (3b9764e) will increase coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4498      +/-   ##
==========================================
+ Coverage   66.76%   66.93%   +0.16%     
==========================================
  Files         197      197              
  Lines       27622    27820     +198     
==========================================
+ Hits        18442    18621     +179     
- Misses       7536     7545       +9     
- Partials     1644     1654      +10     
Impacted Files Coverage Δ
internal/bminventory/inventory.go 70.96% <0.00%> (+1.07%) ⬆️

@omertuc
Copy link
Contributor

omertuc commented Oct 13, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CrystalChun,adriengentil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2022

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3f535bd into openshift:master Oct 14, 2022
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
The kubectl command was missing curly braces. The output
would be: ".spec.resources.requests.storage", causing the
rest of the script to error out.
@CrystalChun CrystalChun deleted the postgres-script branch January 29, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants