Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 4.12.0-ec.5 #4554

Merged

Conversation

osherdp
Copy link
Contributor

@osherdp osherdp commented Oct 30, 2022

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/test edge-e2e-metal-assisted-4-12

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@osherdp
Copy link
Contributor Author

osherdp commented Oct 30, 2022

/hold
/cc @gamli75

@openshift-ci openshift-ci bot requested a review from gamli75 October 30, 2022 12:36
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2022
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #4554 (3d892b6) into master (d8b34cd) will increase coverage by 0.82%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4554      +/-   ##
==========================================
+ Coverage   67.10%   67.92%   +0.82%     
==========================================
  Files         198      198              
  Lines       27945    28546     +601     
==========================================
+ Hits        18752    19390     +638     
+ Misses       7535     7506      -29     
+ Partials     1658     1650       -8     
Impacted Files Coverage Δ
internal/oc/release.go 78.36% <0.00%> (+1.16%) ⬆️
...rollers/hypershiftagentserviceconfig_controller.go 86.86% <0.00%> (+4.97%) ⬆️
...oller/controllers/agentserviceconfig_controller.go 91.12% <0.00%> (+5.20%) ⬆️

@osherdp
Copy link
Contributor Author

osherdp commented Oct 30, 2022

/override ci/prow/images
no change to ocp image, so this test isn't related to this change

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2022

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/images

In response to this:

/override ci/prow/images
no change to ocp image, so this test isn't related to this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor Author

osherdp commented Oct 30, 2022

/retest

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Oct 30, 2022

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osherdp
Copy link
Contributor Author

osherdp commented Oct 30, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2022
@osherdp
Copy link
Contributor Author

osherdp commented Oct 31, 2022

/override ci/prow/edge-subsystem-kubeapi-aws

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/edge-subsystem-kubeapi-aws

In response to this:

/override ci/prow/edge-subsystem-kubeapi-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 31, 2022

@osherdp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 3d892b6 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 70f0790 into openshift:master Oct 31, 2022
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants