MGMT-12398: Regression fix: Move host stage to "Done" only when not in KubeAPI mode.

[paul-maidment]

A recent regression caused the host stage to be prematurely moved to "Done" when the installation is in KubeAPI mode. This change aims to fix that by setting the correct status.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• [] None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
  I used aicli to create a hub/spoke setup and proceeded to use KubeAPI to add a Day2 node to a spoke.
  Prior to this fix, the CSR's of the node would not be signed.
  After this fix, the CSRs are signed correctly and the node joined the cluster successfully.
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[paul-maidment]

cc: @tsorya
cc: @eranco74

[eranco74]

/lgtm

[codecov]

Codecov Report

Merging #4587 (59b21e5) into master (2f4ff0c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4587   +/-   ##
=======================================
  Coverage   67.07%   67.08%           
=======================================
  Files         198      198           
  Lines       27997    27997           
=======================================
+ Hits        18780    18782    +2     
+ Misses       7539     7538    -1     
+ Partials     1678     1677    -1     

Impacted Files	Coverage Δ
internal/host/host.go	74.19% <100.00%> (ø)
internal/oc/release.go	78.36% <0.00%> (+1.16%)	⬆️

[paul-maidment]

/retest

[paul-maidment]

/retest

[openshift-ci]

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.