New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-12662: Add API document for discovery kernel arguments #4669
Conversation
/approve |
/assign @avishayt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, otherwise looks great
# Discovery Kernel Arguments API | ||
|
||
The way to update discovery kernel arguments is by updating InfraEnv. Currently, only **append** (additional argument) operation is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Discovery Kernel Arguments API | |
The way to update discovery kernel arguments is by updating InfraEnv. Currently, only **append** (additional argument) operation is supported. | |
# Modifying Kernel Arguments for the Live ISO | |
Update the InfraEnv resource to modify the kernel arguments used in the live ISO (during the host discovery phase) . Currently, only the **append** (additional argument) operation is supported. |
I suggest also modifying the name of the file, people probably won't guess what "discovery kernel arguments" means.
## Kube API | ||
|
||
With Kube API, the kernel arguments are set in the InfraEnv spec section: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Kube API | |
With Kube API, the kernel arguments are set in the InfraEnv spec section: | |
## Kubernetes API | |
When using the Kubernetes API, the kernel arguments are set in the InfraEnv spec section: |
wont it make more sense to add it here: |
Yes, great point |
61f2258
to
4b98f9a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @filanov