MGMT-12970: don't reset auto-assign for irrelevant hosts #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4891 +/- ##
==========================================
- Coverage 67.77% 67.63% -0.15%
==========================================
Files 202 202
Lines 30100 30183 +83
==========================================
+ Hits 20401 20414 +13
- Misses 7892 7963 +71
+ Partials 1807 1806 -1
|
|
/assign @ori-amizur |
|
/test ci/prow/edge-subsystem-kubeapi-aws |
|
@slaviered: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
slaviered
force-pushed
the
auto-assign-query
branch
2 times, most recently
from
80734b7
to
3f151ce
Compare
ori-amizur
reviewed
Jan 17, 2023
The monitor resets the 'suggested-role' field on all hosts of the clusters if one of the hosts is in auto-assign. This was done to eliminate race conditions between 'register host' and the calculation of auto-assign a synchronically in the monitor loop. The reset may happen once in a lifetime of a host. However, in production, we found several types of obsolete hosts mostly orphan ones that trigger that role clearance all the time The amendment to the query does not reset the roles where the the auto-assign host is not relevant: * in status disabled (obsolete) * disconnected * day2 host (old hosts - current day 2 sets the role to a worker role before registering) * host stuck on discovering state This PR, in combine with future improvements to GC code, will eliminate the spurious resets of auto-assign roles.
slaviered
force-pushed
the
auto-assign-query
branch
from
3f151ce
to
0a0ac44
Compare
|
/retest-required |
|
@slaviered: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ori-amizur
approved these changes
Jan 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur, slaviered The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eliorerz
pushed a commit
to eliorerz/assisted-service
that referenced
this pull request
Jan 29, 2023
) The monitor resets the 'suggested-role' field on all hosts of the clusters if one of the hosts is in auto-assign. This was done to eliminate race conditions between 'register host' and the calculation of auto-assign a synchronically in the monitor loop. The reset may happen once in a lifetime of a host. However, in production, we found several types of obsolete hosts mostly orphan ones that trigger that role clearance all the time The amendment to the query does not reset the roles where the the auto-assign host is not relevant: * in status disabled (obsolete) * disconnected * day2 host (old hosts - current day 2 sets the role to a worker role before registering) * host stuck on discovering state This PR, in combine with future improvements to GC code, will eliminate the spurious resets of auto-assign roles.
danielerez
pushed a commit
to danielerez/assisted-service
that referenced
this pull request
Oct 15, 2023
) The monitor resets the 'suggested-role' field on all hosts of the clusters if one of the hosts is in auto-assign. This was done to eliminate race conditions between 'register host' and the calculation of auto-assign a synchronically in the monitor loop. The reset may happen once in a lifetime of a host. However, in production, we found several types of obsolete hosts mostly orphan ones that trigger that role clearance all the time The amendment to the query does not reset the roles where the the auto-assign host is not relevant: * in status disabled (obsolete) * disconnected * day2 host (old hosts - current day 2 sets the role to a worker role before registering) * host stuck on discovering state This PR, in combine with future improvements to GC code, will eliminate the spurious resets of auto-assign roles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitor resets the 'suggested-role' field on all hosts of the clusters if one of the hosts is in auto-assign. This was done to eliminate race conditions between 'register host' and the calculation of auto-assign a synchronically in the monitor loop.
The reset may happen once in a lifetime of a host.
However, in production, we found several types of obsolete hosts mostly orphan ones that trigger that role clearance all the time
The amendment to the query does not reset the roles where the the auto-assign host is not relevant:
This PR, in combine with future improvements to GC code, will eliminate the spurious resets of auto-assign roles.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist