MGMT-13550: Create day2 support for node labeling #5042
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ori-amizur: This pull request references MGMT-13550 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ori-amizur: This pull request references MGMT-13550 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This pull request references MGMT-13636 . |
|
@ori-amizur: This pull request references MGMT-13550 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5042 +/- ##
==========================================
+ Coverage 67.28% 67.38% +0.09%
==========================================
Files 213 214 +1
Lines 31446 31760 +314
==========================================
+ Hits 21158 21400 +242
- Misses 8403 8450 +47
- Partials 1885 1910 +25
|
|
/test? |
|
@ori-amizur: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-ai-operator-ztp |
1 similar comment
|
/test edge-e2e-ai-operator-ztp |
internal/controller/controllers/clusterdeployments_controller.go
Outdated
Show resolved
Hide resolved
|
/assign @slaviered |
Add day2 support to apply node labels to a day2 spoke cluster MGMT-13636: Pause worker MCP for day2 flow when using K8S API When using K8S API, pause worker MCP when day2 host is being installed and it has custom MCP, and it has node labels. Once all day2 hosts with custom MCP and node labels were installed, the worker MCP is unpaused.
ori-amizur
requested review from
filanov and
tsorya
and removed request for
tsorya and
filanov
|
/lgtm |
|
@ori-amizur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Add day2 support to apply node labels to a day2 spoke cluster MGMT-13636: Pause worker MCP for day2 flow when using K8S API When using K8S API, pause worker MCP when day2 host is being installed and it has custom MCP, and it has node labels. Once all day2 hosts with custom MCP and node labels were installed, the worker MCP is unpaused.
Add day2 support to apply node labels to a day2 spoke cluster
MGMT-13636: Pause worker MCP for day2 flow when using K8S API
When using K8S API, pause worker MCP when day2 host is being installed and it has custom MCP, and it has node labels.
Once all day2 hosts with custom MCP and node labels were installed, the worker MCP is unpaused.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist
/cc @filanov
/cc @tsorya