New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-ocm-2.8] OCPBUGS-13250: Fix disk name in generated HardwareDetails #5195
[release-ocm-2.8] OCPBUGS-13250: Fix disk name in generated HardwareDetails #5195
Conversation
Use a disk 'name' that matches the format returned by ironic inspection in Metal³ when setting the HardwareDetails for a BareMetalHost CR generated by the assisted.
@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-13250 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-13250, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.8 #5195 +/- ##
===================================================
+ Coverage 67.50% 67.95% +0.45%
===================================================
Files 218 218
Lines 32588 33399 +811
===================================================
+ Hits 21997 22695 +698
- Misses 8609 8700 +91
- Partials 1982 2004 +22
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e24b662
into
openshift:release-ocm-2.8
@openshift-cherrypick-robot: Jira Issue OCPBUGS-13250 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #5193
/assign filanov