[release-ocm-2.8] MGMT-14498: Remove the detached annotation when BMH is being deleted #5238
Conversation
When the BMH has the delete annotation the detached annotation value contains metadata that causes BMO to pause its finalizer handling until it is removed. This means that BMAC needs to ensure the detached annotation is removed whenever the BMH is being deleted and the finalizer is going to be removed or is already gone. Previosuly if the agent was deleted BMAC removed the finalizer, but not the detached annotation leading to the BMH not being deleted. https://issues.redhat.com/browse/MGMT-14498
|
@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-14498](https://issues.redhat.com//browse/MGMT-14498) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-ci-robot: This pull request references MGMT-14498 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/M
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.8 #5238 +/- ##
===================================================
+ Coverage 67.48% 67.50% +0.02%
===================================================
Files 218 218
Lines 32615 32620 +5
===================================================
+ Hits 22009 22020 +11
+ Misses 8619 8616 -3
+ Partials 1987 1984 -3
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 3de8b78
into
openshift:release-ocm-2.8
This is an automated cherry-pick of #5228
/assign carbonin