MGMT-13431: ODF storage class not recognizing all available disks in the cluster #5268
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danmanor: This pull request references MGMT-13431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@danmanor: This pull request references MGMT-13431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XS
openshift-ci
bot
added
the
approved
|
/uncc @CrystalChun |
|
@danmanor: This pull request references MGMT-13431 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cc @eranco74 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5268 +/- ##
==========================================
+ Coverage 67.51% 68.44% +0.93%
==========================================
Files 221 221
Lines 32972 33836 +864
==========================================
+ Hits 22260 23160 +900
+ Misses 8709 8658 -51
- Partials 2003 2018 +15
|
|
Rebase you RP |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest edge-e2e-ai-operator-ztp |
|
@danmanor: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-ai-operator-ztp |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-ci
bot
added
size/S
|
/cc @osherdp |
|
/uncc @avishayt |
|
/retitle MGMT-13431: ODF storage class not recognizing all available disks in the cluster |
openshift-ci
bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This bug was discovered in assisted-service with
OpenShiftversion 4.12. It relates to a specific situation where the service generates aStorageClustermanifest containing an incorrect number ofODFdisks. This issue seems to arise when the service uses the default value ofo.config.ODFDisksAvailablein the manifest, as there exists a scenario where this attribute is not properly set with the appropriate count due to the involvement of a separate instance of the service.As a solution, I added an additional count prior to manifest generation. This ensures an accurate count of disks, regardless of whether it is performed by a single instance or multiple instances of the service.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist