MGMT-14750: Allow FC, ECKD, FBA drive types on s390x #5269
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@avishayt: This pull request references MGMT-14750 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/L
openshift-ci
bot
added
api-review
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5269 +/- ##
==========================================
+ Coverage 67.48% 67.57% +0.09%
==========================================
Files 218 221 +3
Lines 32769 33047 +278
==========================================
+ Hits 22113 22333 +220
- Misses 8668 8710 +42
- Partials 1988 2004 +16
|
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Multipath cannot be enabled in day1 on s390x, so we will allow installing directly on an FC path only for this arch. In addition, there are two new drive types for IBM DASDs (direct access storage devices).
avishayt
force-pushed
the
avishay/MGMT-14750
branch
from
43ef6d1
to
5c87429
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
| return []string{string(models.DriveTypeHDD), string(models.DriveTypeSSD), string(models.DriveTypeMultipath)} | ||
| func (v *validator) getValidDeviceStorageTypes(hostArchitecture string) []string { | ||
| validTypes := []string{string(models.DriveTypeHDD), string(models.DriveTypeSSD), string(models.DriveTypeMultipath)} | ||
| if hostArchitecture == models.ClusterCPUArchitectureS390x { |
There was a problem hiding this comment.
do we need to also check that it's not null?
There was a problem hiding this comment.
hostArchitecture is a string, it can't be null
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avishayt, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@avishayt: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Multipath cannot be enabled in day1 on s390x, so we will allow installing directly on an FC path only for this arch. In addition, there are two new drive types for IBM DASDs (direct access storage devices).
Multipath cannot be enabled in day1 on s390x, so we will allow installing directly on an FC path only for this arch. In addition, there are two new drive types for IBM DASDs (direct access storage devices).
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist