MGMT-14756: Add tls config for the service monitor #5282
Conversation
This is identical to how the API server handles configuring its service monitor and it also is using service serving certs. Also remove some complication from the `newServiceMonitor` function and remove the http port from the config as metrics are only served over https. Resolves https://issues.redhat.com/browse/MGMT-14756
openshift-ci-robot
added
the
jira/valid-reference
|
@carbonin: This pull request references MGMT-14756 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5282 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 221 221
Lines 33016 33039 +23
=======================================
+ Hits 22283 22299 +16
- Misses 8723 8728 +5
- Partials 2010 2012 +2
|
|
/retest |
carbonin
requested review from
omertuc
and removed request for
danielerez and
avishayt
|
@omertuc can you take a look at this one? |
|
/lgtm |
|
@carbonin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-ocm-2.8 |
|
@carbonin: new pull request created: #5289 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is identical to how the API server handles configuring its service monitor and it also is using service serving certs. Also remove some complication from the `newServiceMonitor` function and remove the http port from the config as metrics are only served over https. Resolves https://issues.redhat.com/browse/MGMT-14756
This is identical to how the API server handles configuring its service monitor and it also is using service serving certs.
Also remove some complication from the
newServiceMonitorfunction and remove the http port from the config as metrics are only served over https.List all the issues related to this PR
Resolves https://issues.redhat.com/browse/MGMT-14756
What environments does this code impact?
How was this code tested?
Manually deployed the operator build from this branch and saw that the service monitor was deployed correctly.
Checklist
docs, README, etc)Reviewers Checklist