New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-15015 Provider IsHostSupported panic if platform is not found #5306
MGMT-15015 Provider IsHostSupported panic if platform is not found #5306
Conversation
Print the platform from the arguments and not the reply from the get function to avoid using nil reply
/assign @osherdp |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick cloud_hotfix_releases |
@osherdp: once the present PR merges, I will cherry-pick it on top of cloud_hotfix_releases in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
1 similar comment
/retest |
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5306 +/- ##
=======================================
Coverage 67.53% 67.54%
=======================================
Files 221 221
Lines 33123 33123
=======================================
+ Hits 22371 22373 +2
+ Misses 8739 8735 -4
- Partials 2013 2015 +2
|
/retest |
@filanov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@osherdp: new pull request created: #5311 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…penshift#5306) Print the platform from the arguments and not the reply from the get function to avoid using nil reply
Print the platform from the arguments and not the reply from the get function to avoid using nil reply
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist