Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15015 Provider IsHostSupported panic if platform is not found #5306

Conversation

filanov
Copy link
Contributor

@filanov filanov commented Jun 20, 2023

Print the platform from the arguments and not the reply from the get function to avoid using nil reply

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • [] No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Print the platform from the arguments and not the reply from the get function to avoid using nil reply
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@filanov
Copy link
Contributor Author

filanov commented Jun 20, 2023

/assign @osherdp

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osherdp
Copy link
Contributor

osherdp commented Jun 20, 2023

/cherry-pick cloud_hotfix_releases

@openshift-cherrypick-robot

@osherdp: once the present PR merges, I will cherry-pick it on top of cloud_hotfix_releases in a new PR and assign it to you.

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@osherdp
Copy link
Contributor

osherdp commented Jun 20, 2023

/retest

1 similar comment
@filanov
Copy link
Contributor Author

filanov commented Jun 20, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cab4a19 and 2 for PR HEAD 465f536 in total

@filanov
Copy link
Contributor Author

filanov commented Jun 20, 2023

/retest
something is wrong with the CI

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #5306 (465f536) into master (cab4a19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5306   +/-   ##
=======================================
  Coverage   67.53%   67.54%           
=======================================
  Files         221      221           
  Lines       33123    33123           
=======================================
+ Hits        22371    22373    +2     
+ Misses       8739     8735    -4     
- Partials     2013     2015    +2     
Impacted Files Coverage Δ
internal/provider/registry/registry.go 64.28% <100.00%> (+7.14%) ⬆️

... and 1 file with indirect coverage changes

@filanov
Copy link
Contributor Author

filanov commented Jun 21, 2023

/retest
Opened a bug MGMT-15029 for subsystem

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2023

@filanov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 052e7fa into openshift:master Jun 21, 2023
14 checks passed
@openshift-cherrypick-robot

@osherdp: new pull request created: #5311

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@filanov filanov deleted the provider-is-host-supported-panic branch June 21, 2023 08:39
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
…penshift#5306)

Print the platform from the arguments and not the reply from the get function to avoid using nil reply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants