MGMT-15114: remove event for cluster registration failed

[rccrdpccl]

Related to #5324

We decided that ClusterRegistrationFailed event it's useless as it is, therefore we're going to remove it.

In this PR we'll also include migration to clean up events not bound to clusters.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@rccrdpccl: This pull request references MGMT-15114 which is a valid jira issue.

In response to this:

Related to #5324

We decided that ClusterRegistrationFailed event it's useless as it is, therefore we're going to remove it.

In this PR we'll also include migration to clean up events not bound to clusters.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rccrdpccl]

/cc @avishayt @osherdp @gamli75

[rccrdpccl]

/uncc @eliorerz @romfreiman

[avishayt]

We can also clean up the event definition itself

[codecov]

Codecov Report

Merging #5330 (ac3bba9) into master (5d319db) will increase coverage by 0.23%.
The diff coverage is 64.28%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5330      +/-   ##
==========================================
+ Coverage   67.49%   67.72%   +0.23%     
==========================================
  Files         225      226       +1     
  Lines       33214    33397     +183     
==========================================
+ Hits        22417    22619     +202     
+ Misses       8781     8763      -18     
+ Partials     2016     2015       -1     

Impacted Files	Coverage Δ
internal/bminventory/inventory.go	69.85% <ø> (+0.02%)	⬆️
internal/cluster/cluster.go	66.57% <0.00%> (+0.06%)	⬆️
...230629113604_delete_events_with_unbound_cluster.go	80.00% <80.00%> (ø)
internal/migrations/migrations.go	89.28% <100.00%> (+0.39%)	⬆️

... and 2 files with indirect coverage changes

[rccrdpccl]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5d319db and 2 for PR HEAD d29b291 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a6fd277 and 2 for PR HEAD ac3bba9 in total

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, gamli75, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avishayt,gamli75,rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gamli75]

/retest-required

[openshift-ci]

@rccrdpccl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[osherdp]

/cherry-pick cloud_hotfix_releases

[openshift-cherrypick-robot]

@osherdp: new pull request created: #5332

In response to this:

/cherry-pick cloud_hotfix_releases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.