[release-ocm-2.8] OCPBUGS-15813: Fix singular Ingress and API cluster VIPs removal #5337
Conversation
This change fixes a case where the user attempts to remove Ingress and API VIPs. Cleanup used to fail due to a missing deletion as a part of the deletion db transaction. Added unit tests to verify all deletion combination works for singular, plural, and a combination of VIP params.
|
@openshift-cherrypick-robot: Could not make automatic cherrypick of Jira Issue OCPBUGS-13621 for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
jira/severity-important
|
@openshift-ci-robot: This pull request references Jira Issue OCPBUGS-13621, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/L
|
/retitle [release-ocm-2.8] OCPBUGS-15813: Fix singular Ingress and API cluster VIPs removal |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15813, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.8 #5337 +/- ##
================================================
Coverage 67.52% 67.53%
================================================
Files 218 218
Lines 32709 32731 +22
================================================
+ Hits 22088 22104 +16
- Misses 8631 8638 +7
+ Partials 1990 1989 -1
|
filanov
removed
the
jira/invalid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 91db753
into
openshift:release-ocm-2.8
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-15813: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-15813 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102 |
|
Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050 |
|
Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929 |
This is an automated cherry-pick of #5216
/assign nmagnezi