Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-15070: Unable to change machine-network with dual stack #5349

Merged
merged 1 commit into from Jul 11, 2023
Merged

MGMT-15070: Unable to change machine-network with dual stack #5349

merged 1 commit into from Jul 11, 2023

Conversation

ori-amizur
Copy link
Contributor

When working with dual stack, and there is an attempt to update the machine networks only, they are not updated. This change fixes it.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @filanov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 10, 2023 •
edited by openshift-ci bot

@ori-amizur: This pull request references MGMT-15070 which is a valid jira issue.

In response to this:

When working with dual stack, and there is an attempt to update the machine networks only, they are not updated. This change fixes it.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from filanov July 10, 2023 16:56
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited

Codecov Report

Merging #5349 (88a5918) into master (820a271) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5349      +/-   ##
==========================================
+ Coverage   67.54%   67.56%   +0.01%     
==========================================
  Files         226      226              
  Lines       33278    33280       +2     
==========================================
+ Hits        22476    22484       +8     
+ Misses       8775     8771       -4     
+ Partials     2027     2025       -2
Impacted Files Coverage Δ
internal/bminventory/inventory.go 69.88% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

@filanov
Copy link
Contributor

filanov commented Jul 11, 2023

/assign @nmagnezi

@ori-amizur
MGMT-15070: Unable to change machine-network with dual stack
88a5918 
When working with dual stack, and there is an attempt to update the
machine networks only, they are not updated.  This change fixes it.
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [avishayt,ori-amizur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 61b295a into openshift:master Jul 11, 2023
14 checks passed
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
@ori-amizur @CrystalChun
MGMT-15070: Unable to change machine-network with dual stack (openshi…
36d0329 
…ft#5349)

When working with dual stack, and there is an attempt to update the
machine networks only, they are not updated.  This change fixes it.
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
@ori-amizur @danielerez
MGMT-15070: Unable to change machine-network with dual stack (openshi…
61cf4c2 
…ft#5349)

When working with dual stack, and there is an attempt to update the
machine networks only, they are not updated.  This change fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filanov filanov filanov left review comments

@avishayt avishayt avishayt approved these changes

Assignees

@nmagnezi nmagnezi

@avishayt avishayt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ori-amizur @openshift-ci-robot @filanov @avishayt @nmagnezi @openshift-merge-robot