Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15339: Run network config before NetworkManager #5375

Commits on Jul 21, 2023

  1. MGMT-15339: Run network config before NetworkManager

    Currently the systemd service that we use to apply static network
    configuration from the non-minimal discovery environment wants to run
    after `dracut-cmdline.service` and before `dracut-initqueue.service`.
    But that isn't possible because this service is created by an ignition
    configuration, and services created that way only run after the root has
    pivoted, and at that point the `cmdline` and `initqueue` steps of Dracut
    have already been completed.
    
    The net result is that this ordering dependencies are just ignored, and
    the service will run as part of `multi-user.target` without any special
    ordering restriction. It may even run after NetworkManager. If that
    happens then the configuration files that it generates will be ignored.
    That is unlikely, but it has been observed when there are many network
    interfaces with static configuration. To avoid that the service should
    be explicitly configured to run before NetworkManager.
    
    Note that there is another diferent systemd service that is used to
    generate the network config when using the minimal ISO. That is added
    directly to the initrd, not via ignition. It runs before the root pivots
    because the network is needed to fetch the root file system. This patch
    doesn't change that service.
    
    Related: https://issues.redhat.com/browse/MGMT-15339
    Related: https://issues.redhat.com//browse/OCPBUGS-16219
    Related: openshift/installer#7355
    Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
    jhernand committed Jul 21, 2023
    Copy the full SHA
    ea545d1 View commit details
    Browse the repository at this point in the history