AGENT-557: Split register into registerCluster and registerInfraEnv #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
jira/valid-reference
|
@rwsu: This pull request references AGENT-557 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5376 +/- ##
==========================================
+ Coverage 67.59% 67.90% +0.31%
==========================================
Files 226 226
Lines 33304 34044 +740
==========================================
+ Hits 22513 23119 +606
- Misses 8758 8876 +118
- Partials 2033 2049 +16
|
The split is desired to enable the interactive flow. Users will register the cluster through the GUI instead of including the cluster information in the ignition/agent ISO. registerCluster is able to detect if a cluster has already been registered with the REST-API and exits with status 0, skipping cluster registration from manifest files. registerInfraEnv requires and checks that a cluster has been registered with the REST-API. It also skips infraenv registration if it detects one has already been created. Signed-off-by: Richard Su <rwsu@redhat.com>
rwsu
added a commit
to rwsu/installer
that referenced
this pull request
Jul 25, 2023
The service has been removed and split into agent-register-cluster.service agent-register-infraenv.service Both services continuously retries until their respective resource has been registered with the assisted-service REST-API or if the client sees that a resource as already been registered. Requires: openshift/assisted-service#5376 Signed-off-by: Richard Su <rwsu@redhat.com>
|
/retest-required |
|
/test edge-subsystem-kubeapi-aws |
|
@rwsu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rwsu
added a commit
to rwsu/installer
that referenced
this pull request
Jul 31, 2023
The service has been removed and split into agent-register-cluster.service agent-register-infraenv.service Both services continuously retries until their respective resource has been registered with the assisted-service REST-API or if the client sees that a resource as already been registered. Requires: openshift/assisted-service#5376 Signed-off-by: Richard Su <rwsu@redhat.com>
CrystalChun
pushed a commit
to CrystalChun/assisted-service
that referenced
this pull request
Aug 25, 2023
…penshift#5376) The split is desired to enable the interactive flow. Users will register the cluster through the GUI instead of including the cluster information in the ignition/agent ISO. registerCluster is able to detect if a cluster has already been registered with the REST-API and exits with status 0, skipping cluster registration from manifest files. registerInfraEnv requires and checks that a cluster has been registered with the REST-API. It also skips infraenv registration if it detects one has already been created. Signed-off-by: Richard Su <rwsu@redhat.com>
rwsu
added a commit
to rwsu/installer
that referenced
this pull request
Oct 9, 2023
The service has been removed and split into agent-register-cluster.service agent-register-infraenv.service Both services continuously retries until their respective resource has been registered with the assisted-service REST-API or if the client sees that a resource as already been registered. Requires: openshift/assisted-service#5376 Signed-off-by: Richard Su <rwsu@redhat.com>
danielerez
pushed a commit
to danielerez/assisted-service
that referenced
this pull request
Oct 15, 2023
…penshift#5376) The split is desired to enable the interactive flow. Users will register the cluster through the GUI instead of including the cluster information in the ignition/agent ISO. registerCluster is able to detect if a cluster has already been registered with the REST-API and exits with status 0, skipping cluster registration from manifest files. registerInfraEnv requires and checks that a cluster has been registered with the REST-API. It also skips infraenv registration if it detects one has already been created. Signed-off-by: Richard Su <rwsu@redhat.com>
rwsu
added a commit
to rwsu/installer
that referenced
this pull request
Oct 20, 2023
The service has been removed and split into agent-register-cluster.service agent-register-infraenv.service Both services continuously retries until their respective resource has been registered with the assisted-service REST-API or if the client sees that a resource as already been registered. Requires: openshift/assisted-service#5376 Signed-off-by: Richard Su <rwsu@redhat.com>
rwsu
added a commit
to rwsu/installer
that referenced
this pull request
Nov 1, 2023
The service has been removed and split into agent-register-cluster.service agent-register-infraenv.service Both services continuously retries until their respective resource has been registered with the assisted-service REST-API or if the client sees that a resource as already been registered. Requires: openshift/assisted-service#5376 Signed-off-by: Richard Su <rwsu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split is desired to enable the interactive flow. Users will register the cluster through the GUI instead of including the cluster information in the ignition/agent ISO.
registerCluster is able to detect if a cluster has already been registered with the REST-API and exits with status 0, skipping cluster registration from manifest files.
registerInfraEnv requires and checks that a cluster has been registered with the REST-API. It also skips infraenv registration if it detects one has already been created.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist