Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-15343: dependabot group updates #5379

Merged
merged 1 commit into from Jul 24, 2023
Merged

MGMT-15343: dependabot group updates #5379

merged 1 commit into from Jul 24, 2023

Conversation

eifrach
Copy link
Contributor

@eifrach eifrach commented Jul 24, 2023 •
edited

  • grouping all dependencies to a single PR
  • changed label to dependabot for easier filtering and searching
  • add label for a type of change docker / go etc ..

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2023 •
edited by openshift-ci bot

@eifrach: This pull request references MGMT-15343 which is a valid jira issue.

In response to this:

This is PR for grouping all dependencies to a single PR

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 24, 2023
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2023 •
edited by openshift-ci bot

@eifrach: This pull request references MGMT-15343 which is a valid jira issue.

In response to this:

  • grouping all dependencies to a single PR
  • changed label to dependabot for easier filtering and searching

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2023 •
edited by openshift-ci bot

@eifrach: This pull request references MGMT-15343 which is a valid jira issue.

In response to this:

  • grouping all dependencies to a single PR
  • changed label to dependabot for easier filtering and searching
  • add label for a type of change docker / go etc ..

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eifrach eifrach marked this pull request as ready for review July 24, 2023 09:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
@eifrach
Copy link
Contributor Author

eifrach commented Jul 24, 2023

/assign @osherdp
/assign @adriengentil

@eifrach
Copy link
Contributor Author

eifrach commented Jul 24, 2023

/unassign @osherdp
/unassign @adriengentil

/cc @osherdp
/cc @adriengentil

@openshift-ci openshift-ci bot requested a review from osherdp July 24, 2023 10:01
adriengentil
adriengentil reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@adriengentil adriengentil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just a question

.github/dependabot.yml
Comment on lines +29 to +30
- "dependabot"
- "docker"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osherdp any reasons we don't lgtm+approve docker updates?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah those updates are basically irrelevant I'm afraid
because when the base-image changes we usually need to do changes in openshift/release repo and in the D/S Dockerfiles, and it's rarely trivial changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we even prefer removing those bumps as they only act as reminders. wdyt @adriengentil ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I think it's fine, as you say it, it acts as a reminder :)

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #5379 (5c39105) into master (36d3543) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5379   +/-   ##
=======================================
  Coverage   67.67%   67.67%           
=======================================
  Files         226      226           
  Lines       33349    33349           
=======================================
  Hits        22570    22570           
  Misses       8745     8745           
  Partials     2034     2034

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6a583ef into openshift:master Jul 24, 2023
10 checks passed
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Jul 25, 2023
@eifrach @CrystalChun
MGMT-15343: dependabot group updates (openshift#5379)
932e179
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
@eifrach @CrystalChun
MGMT-15343: dependabot group updates (openshift#5379)
c250949
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
@eifrach @danielerez
MGMT-15343: dependabot group updates (openshift#5379)
41a7991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengentil adriengentil adriengentil approved these changes

@eranco74 eranco74 Awaiting requested review from eranco74

@osherdp osherdp Awaiting requested review from osherdp

Assignees

@adriengentil adriengentil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eifrach @openshift-ci-robot @adriengentil @osherdp @openshift-merge-robot