MGMT-15388: Remove unsupported platforms from the supported-platforms endpoint #5394
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eliorerz: This pull request references MGMT-15388 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
size/M
eliorerz
force-pushed
the
MGMT-15388_Remove_unsupported_platforms_from_the_supported-platforms_endpoint
branch
from
31e1be9
to
9570bd8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5394 +/- ##
==========================================
- Coverage 67.69% 67.57% -0.12%
==========================================
Files 226 226
Lines 33386 33434 +48
==========================================
- Hits 22600 22594 -6
- Misses 8749 8807 +58
+ Partials 2037 2033 -4
|
|
/retest |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, eliorerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test ? |
|
@eliorerz: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-nutanix-assisted edge-e2e-vsphere-assisted |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@eliorerz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 618995b
into
openshift:master
eliorerz
deleted the
MGMT-15388_Remove_unsupported_platforms_from_the_supported-platforms_endpoint
branch
Currently we check for the hosts supported platforms and return it without taking in any consideration if the platform is supported in the cluster openshift version or CPU architecture.
This PR uses feature support to remove the not supported platforms before returning the actual value to the user.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
/cc @eliorerz