Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-11949: MGMT-12278: Update libksba and libxml2 #5398

Merged

Conversation

eliorerz
Copy link
Contributor

@eliorerz eliorerz commented Jul 31, 2023

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @gamli75 @osherdp

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023

@eliorerz: This pull request references MGMT-12278 which is a valid jira issue.

In response to this:

Update libksba to its latest version (currently libksba-1.3.5-9.el8.x86_64) which include the fix for CVE-2022-3515

integer overflow may lead to remote code execution

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @gamli75 @osherdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from gamli75 and osherdp July 31, 2023 07:49
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/dependency-change Categorizes issue or PR as related to changing dependencies approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #5398 (d8eab18) into master (83852f8) will decrease coverage by 0.07%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5398      +/-   ##
==========================================
- Coverage   67.69%   67.62%   -0.07%     
==========================================
  Files         226      226              
  Lines       33386    33408      +22     
==========================================
- Hits        22600    22592       -8     
- Misses       8749     8782      +33     
+ Partials     2037     2034       -3     

see 8 files with indirect coverage changes

@gamli75
Copy link
Contributor

gamli75 commented Jul 31, 2023

@eliorerz eliorerz force-pushed the MGMT-12278_Fix_CVE-2022-3515 branch 2 times, most recently from 6de8760 to 5c96334 Compare July 31, 2023 09:20
@eliorerz eliorerz changed the title MGMT-12278: Fix CVE-2022-3515 MGMT-11949: MGMT-12278: Fix CVE-2022-3515 and CVE-2016-3709 Jul 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023

@eliorerz: This pull request references MGMT-11949 which is a valid jira issue.

In response to this:

Update libksba to its latest version (currently libksba-1.3.5-9.el8.x86_64) which include the fix for CVE-2022-3515

integer overflow may lead to remote code execution

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @gamli75 @osherdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz
Copy link
Contributor Author

do we need to do this also in the DS docker file?

The fix is included in ubi8-minimal:8.7-923 (rhacm-2.4-rhel-8) but not in ubi8-minimal:8.6-902.1661794353 (rhacm-2.3-rhel-8)

@eliorerz
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@eliorerz eliorerz changed the title MGMT-11949: MGMT-12278: Fix CVE-2022-3515 and CVE-2016-3709 MGMT-11949: MGMT-12278: Update libksba and libxml2 Jul 31, 2023
@eliorerz eliorerz force-pushed the MGMT-12278_Fix_CVE-2022-3515 branch from 5c96334 to d8eab18 Compare July 31, 2023 12:08
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023

@eliorerz: This pull request references MGMT-11949 which is a valid jira issue.

In response to this:

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @gamli75 @osherdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eliorerz
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 31, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

@eliorerz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a2c382b into openshift:master Jul 31, 2023
14 checks passed
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants