[release-ocm-2.8] MGMT-15413: Use same installer binary for all platform types (#5334)

[CrystalChun]

Cherry-pick of #5334
https://issues.redhat.com/browse/MGMT-15413

• MGMT-15150: Use same installer binary for all platform types

There's nothing special about platform:none that requires it to use a different installer binary. This was originally done (in f9b2f3d) to avoid a problem with the openshift-baremetal-install binary not being available for non-x86 targets, but this was resolved by 1d025b8 (MGMT-9206).

• Remove platform argument when extracting installer

Since we no longer use different installer binaries for different platforms, we no longer need to pass the platform type down. This allows us to clean up a lot of function signatures.

This partially reverts commit f9b2f3d.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@CrystalChun: This pull request references MGMT-15413 which is a valid jira issue.

In response to this:

Cherry-pick of #5334
https://issues.redhat.com/browse/MGMT-15413

• MGMT-15150: Use same installer binary for all platform types

There's nothing special about platform:none that requires it to use a different installer binary. This was originally done (in f9b2f3d) to avoid a problem with the openshift-baremetal-install binary not being available for non-x86 targets, but this was resolved by 1d025b8 (MGMT-9206).

• Remove platform argument when extracting installer

Since we no longer use different installer binaries for different platforms, we no longer need to pass the platform type down. This allows us to clean up a lot of function signatures.

This partially reverts commit f9b2f3d.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@CrystalChun: This pull request references MGMT-15413 which is a valid jira issue.

In response to this:

Cherry-pick of #5334
https://issues.redhat.com/browse/MGMT-15413

• MGMT-15150: Use same installer binary for all platform types

There's nothing special about platform:none that requires it to use a different installer binary. This was originally done (in f9b2f3d) to avoid a problem with the openshift-baremetal-install binary not being available for non-x86 targets, but this was resolved by 1d025b8 (MGMT-9206).

• Remove platform argument when extracting installer

Since we no longer use different installer binaries for different platforms, we no longer need to pass the platform type down. This allows us to clean up a lot of function signatures.

This partially reverts commit f9b2f3d.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5408 (c5c9b78) into release-ocm-2.8 (b6735c2) will decrease coverage by 0.01%.
The diff coverage is 70.58%.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           release-ocm-2.8    #5408      +/-   ##
===================================================
- Coverage            67.50%   67.49%   -0.01%     
===================================================
  Files                  218      218              
  Lines                32721    32721              
===================================================
- Hits                 22088    22086       -2     
- Misses                8641     8642       +1     
- Partials              1992     1993       +1     

Files Changed	Coverage Δ
internal/bminventory/inventory.go	69.85% <ø> (-0.01%)	⬇️
internal/ignition/dummy.go	0.00% <0.00%> (ø)
internal/ignition/ignition.go	59.62% <0.00%> (ø)
internal/oc/release.go	71.83% <81.81%> (+0.11%)	⬆️
internal/installercache/installercache.go	70.51% <100.00%> (ø)

... and 1 file with indirect coverage changes

[CrystalChun]

/cc @filanov

[CrystalChun]

/retest-required

[openshift-ci]

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [filanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment