MGMT-15491: Validate vSphere disk.EnableUUID ignoring cluster platform #5416
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eliorerz: This pull request references MGMT-15491 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eliorerz: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
size/XS
|
/test edge-unit-test edge-subsystem-aws |
|
Lets understand whether this is indeed the right behavior. And in case it's a blocking validation... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5416 +/- ##
==========================================
- Coverage 67.69% 67.65% -0.04%
==========================================
Files 226 227 +1
Lines 33386 33430 +44
==========================================
+ Hits 22600 22617 +17
- Misses 8749 8777 +28
+ Partials 2037 2036 -1
|
eliorerz
force-pushed
the
MGMT-15491_Validate_vSphere_disk.EnableUUID_ignoring_cluster_platform
branch
from
4262b07
to
5c19d95
Compare
openshift-ci
bot
added
size/L
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @gamli75 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
eliorerz
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
eliorerz
force-pushed
the
MGMT-15491_Validate_vSphere_disk.EnableUUID_ignoring_cluster_platform
branch
from
5c19d95
to
6d5b34c
Compare
eliorerz
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/edge-e2e-metal-assisted |
|
@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-metal-assisted In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eliorerz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
eliorerz
deleted the
MGMT-15491_Validate_vSphere_disk.EnableUUID_ignoring_cluster_platform
branch
If disk.EnableUUID flag is not enabled on vSphere VMs in any platform, including baremetal, then no symlinks are generated in /dev/disk/by-id for attached disks.
Installing ODF via LSO or something on such a platform results in somewhat fragile installation because disks themselves could be renamed on reboot and since no permanent ids exists for disks, the PVs could become invalid.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
/cc @eliorerz