Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15525: Use go 1.18 when setting up environment #5422

Merged
merged 1 commit into from Aug 15, 2023

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Aug 9, 2023

Without this this command was failing with the following output:

[2023-08-09 17:01:25] + /tmp/golang_installer
[2023-08-09 17:01:25] Welcome to the Go installer!
[2023-08-09 17:01:26] Downloading Go version go1.21.0
[2023-08-09 17:01:26] time 2023-08-04T20:14:06Z to /root/.go
[2023-08-09 17:01:26] This may take a bit of time...
[2023-08-09 17:01:26] Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)

Also correct a minor typo in a function name.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see [CONTRIBUTING] guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@carbonin
Copy link
Member Author

carbonin commented Aug 9, 2023

/test?

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

@carbonin: The following commands are available to trigger required jobs:

  • /test e2e-agent-compact-ipv4
  • /test edge-assisted-operator-catalog-publish-verify
  • /test edge-ci-index
  • /test edge-e2e-ai-operator-ztp
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding
  • /test edge-e2e-metal-assisted
  • /test edge-e2e-metal-assisted-4-10
  • /test edge-e2e-metal-assisted-4-11
  • /test edge-e2e-metal-assisted-4-12
  • /test edge-e2e-metal-assisted-4-9
  • /test edge-e2e-metal-assisted-cnv
  • /test edge-e2e-metal-assisted-lvm
  • /test edge-e2e-metal-assisted-odf
  • /test edge-images
  • /test edge-lint
  • /test edge-subsystem-aws
  • /test edge-subsystem-kubeapi-aws
  • /test edge-unit-test
  • /test edge-verify-generated-code
  • /test images
  • /test mce-images

The following commands are available to trigger optional jobs:

  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv6
  • /test edge-e2e-ai-operator-ztp-3masters
  • /test edge-e2e-ai-operator-ztp-capi
  • /test edge-e2e-ai-operator-ztp-compact-day2-masters
  • /test edge-e2e-ai-operator-ztp-compact-day2-workers
  • /test edge-e2e-ai-operator-ztp-disconnected
  • /test edge-e2e-ai-operator-ztp-hypershift-zero-nodes
  • /test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp-411
  • /test edge-e2e-ai-operator-ztp-multiarch-sno-ocp-411
  • /test edge-e2e-ai-operator-ztp-node-labels
  • /test edge-e2e-ai-operator-ztp-sno-day2-masters
  • /test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride
  • /test edge-e2e-metal-assisted-4-13
  • /test edge-e2e-metal-assisted-4-14
  • /test edge-e2e-metal-assisted-cnv-4.14
  • /test edge-e2e-metal-assisted-day2
  • /test edge-e2e-metal-assisted-day2-arm-workers
  • /test edge-e2e-metal-assisted-day2-single-node
  • /test edge-e2e-metal-assisted-ipv4v6
  • /test edge-e2e-metal-assisted-ipv6
  • /test edge-e2e-metal-assisted-kube-api-late-binding-single-node
  • /test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
  • /test edge-e2e-metal-assisted-kube-api-net-suite
  • /test edge-e2e-metal-assisted-mce
  • /test edge-e2e-metal-assisted-mce-4-10
  • /test edge-e2e-metal-assisted-mce-sno
  • /test edge-e2e-metal-assisted-metallb
  • /test edge-e2e-metal-assisted-none
  • /test edge-e2e-metal-assisted-odf-4-14
  • /test edge-e2e-metal-assisted-onprem
  • /test edge-e2e-metal-assisted-single-node
  • /test edge-e2e-metal-assisted-static-ip-suite
  • /test edge-e2e-metal-assisted-tang
  • /test edge-e2e-metal-assisted-tpmv2
  • /test edge-e2e-metal-assisted-upgrade-agent
  • /test edge-e2e-nutanix-assisted
  • /test edge-e2e-nutanix-assisted-2workers
  • /test edge-e2e-oci-assisted
  • /test edge-e2e-vsphere-assisted
  • /test edge-e2e-vsphere-assisted-4-12
  • /test edge-e2e-vsphere-assisted-4-13
  • /test edge-e2e-vsphere-assisted-umn
  • /test edge-push-pr-image
  • /test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-images
  • pull-ci-openshift-assisted-service-master-mce-images

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from rccrdpccl and tsorya August 9, 2023 14:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@carbonin
Copy link
Member Author

carbonin commented Aug 9, 2023

/test edge-e2e-ai-operator-ztp-disconnected

@carbonin
Copy link
Member Author

carbonin commented Aug 9, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #5422 (cc0b61f) into master (2585693) will increase coverage by 0.02%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5422      +/-   ##
==========================================
+ Coverage   67.63%   67.66%   +0.02%     
==========================================
  Files         227      227              
  Lines       33427    33452      +25     
==========================================
+ Hits        22609    22635      +26     
+ Misses       8780     8779       -1     
  Partials     2038     2038              

see 3 files with indirect coverage changes

@avishayt
Copy link
Contributor

avishayt commented Aug 9, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Aug 9, 2023
@carbonin
Copy link
Member Author

carbonin commented Aug 9, 2023

/test edge-e2e-ai-operator-ztp-disconnected

@carbonin
Copy link
Member Author

/retest

@carbonin
Copy link
Member Author

/test edge-e2e-ai-operator-ztp-disconnected

1 similar comment
@carbonin
Copy link
Member Author

/test edge-e2e-ai-operator-ztp-disconnected

@carbonin
Copy link
Member Author

/test edge-e2e-ai-operator-ztp-disconnected

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2023
@carbonin
Copy link
Member Author

Disconnected job passed 🤷‍♂️ removing WIP

@carbonin carbonin marked this pull request as ready for review August 14, 2023 13:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2023
@carbonin
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@carbonin carbonin changed the title Correct function typo MGMT-15525: Use go 1.18 when setting up environment Aug 14, 2023
@carbonin
Copy link
Member Author

/test e2e-agent-compact-ipv4

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9884233 and 2 for PR HEAD ddf2620 in total

@gamli75
Copy link
Contributor

gamli75 commented Aug 15, 2023

/test e2e-agent-compact-ipv4

1 similar comment
@carbonin
Copy link
Member Author

/test e2e-agent-compact-ipv4

Without this this command was failing with the following output:

```
[2023-08-09 17:01:25] + /tmp/golang_installer
[2023-08-09 17:01:25] Welcome to the Go installer!
[2023-08-09 17:01:26] Downloading Go version go1.21.0
[2023-08-09 17:01:26] time 2023-08-04T20:14:06Z to /root/.go
[2023-08-09 17:01:26] This may take a bit of time...
[2023-08-09 17:01:26] Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)
```
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, filanov, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [carbonin,filanov,gamli75]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9884233 and 2 for PR HEAD cc0b61f in total

@carbonin
Copy link
Member Author

/test e2e-agent-compact-ipv4

@carbonin
Copy link
Member Author

/override e2e-agent-compact-ipv4

known dev-scripts issue

@carbonin
Copy link
Member Author

/override ci/prow/e2e-agent-compact-ipv4

@carbonin
Copy link
Member Author

/override e2e-agent-compact-ipv4

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@carbonin: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-agent-compact-ipv4

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agent-compact-ipv4
  • ci/prow/edge-ci-index
  • ci/prow/edge-e2e-ai-operator-ztp
  • ci/prow/edge-e2e-metal-assisted
  • ci/prow/edge-images
  • ci/prow/edge-lint
  • ci/prow/edge-subsystem-aws
  • ci/prow/edge-subsystem-kubeapi-aws
  • ci/prow/edge-unit-test
  • ci/prow/edge-verify-generated-code
  • ci/prow/images
  • ci/prow/mce-images
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-mce-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-agent-compact-ipv4

known dev-scripts issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@carbonin: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-agent-compact-ipv4

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agent-compact-ipv4
  • ci/prow/edge-ci-index
  • ci/prow/edge-e2e-ai-operator-ztp
  • ci/prow/edge-e2e-metal-assisted
  • ci/prow/edge-images
  • ci/prow/edge-lint
  • ci/prow/edge-subsystem-aws
  • ci/prow/edge-subsystem-kubeapi-aws
  • ci/prow/edge-unit-test
  • ci/prow/edge-verify-generated-code
  • ci/prow/images
  • ci/prow/mce-images
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
  • pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-assisted-service-master-edge-ci-index
  • pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
  • pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
  • pull-ci-openshift-assisted-service-master-edge-images
  • pull-ci-openshift-assisted-service-master-edge-lint
  • pull-ci-openshift-assisted-service-master-edge-subsystem-aws
  • pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
  • pull-ci-openshift-assisted-service-master-edge-unit-test
  • pull-ci-openshift-assisted-service-master-edge-verify-generated-code
  • pull-ci-openshift-assisted-service-master-mce-images
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@carbonin: Overrode contexts on behalf of carbonin: ci/prow/e2e-agent-compact-ipv4

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2023

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7ebd8dc into openshift:master Aug 15, 2023
14 checks passed
@carbonin carbonin deleted the pogress branch August 15, 2023 20:08
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
Without this this command was failing with the following output:

```
[2023-08-09 17:01:25] + /tmp/golang_installer
[2023-08-09 17:01:25] Welcome to the Go installer!
[2023-08-09 17:01:26] Downloading Go version go1.21.0
[2023-08-09 17:01:26] time 2023-08-04T20:14:06Z to /root/.go
[2023-08-09 17:01:26] This may take a bit of time...
[2023-08-09 17:01:26] Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)
```
@openshift-cherrypick-robot

@adriengentil: new pull request created: #5455

In response to this:

/cherry-pick release-ocm-2.8

Failing in the same way in all other branches:
https://search.ci.openshift.org/?search=Downloading+Go+from+400+Bad+Request+failed+with+HTTP+status&maxAge=168h&context=1&type=build-log&name=.*assisted.*&excludeName=&maxMatches=5&maxBytes=20971520&groupBy=job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Without this this command was failing with the following output:

```
[2023-08-09 17:01:25] + /tmp/golang_installer
[2023-08-09 17:01:25] Welcome to the Go installer!
[2023-08-09 17:01:26] Downloading Go version go1.21.0
[2023-08-09 17:01:26] time 2023-08-04T20:14:06Z to /root/.go
[2023-08-09 17:01:26] This may take a bit of time...
[2023-08-09 17:01:26] Downloading Go from 400 Bad Request failed with HTTP status %!s(MISSING)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants