New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Extend waiting time to test DB container to be ready #5425
NO-ISSUE: Extend waiting time to test DB container to be ready #5425
Conversation
@eliorerz: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
==========================================
- Coverage 67.69% 67.64% -0.05%
==========================================
Files 226 227 +1
Lines 33386 33427 +41
==========================================
+ Hits 22600 22612 +12
- Misses 8749 8779 +30
+ Partials 2037 2036 -1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/edge-e2e-metal-assisted |
@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-metal-assisted In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eliorerz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sometimes when debugging unittest without skipper the 5 seconds timeout is not enough and will fail if the test start before DB container is ready.
This PR extend the waiting to 30 seconds which is most of the time is enough.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
/cc @osherdp @adriengentil