Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Extend waiting time to test DB container to be ready #5425

Conversation

eliorerz
Copy link
Contributor

Sometimes when debugging unittest without skipper the 5 seconds timeout is not enough and will fail if the test start before DB container is ready.
This PR extend the waiting to 30 seconds which is most of the time is enough.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @osherdp @adriengentil

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 10, 2023
@openshift-ci-robot
Copy link

@eliorerz: This pull request explicitly references no jira issue.

In response to this:

Sometimes when debugging unittest without skipper the 5 seconds timeout is not enough and will fail if the test start before DB container is ready.
This PR extend the waiting to 30 seconds which is most of the time is enough.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @osherdp @adriengentil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #5425 (8888a5e) into master (83852f8) will decrease coverage by 0.05%.
Report is 23 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5425      +/-   ##
==========================================
- Coverage   67.69%   67.64%   -0.05%     
==========================================
  Files         226      227       +1     
  Lines       33386    33427      +41     
==========================================
+ Hits        22600    22612      +12     
- Misses       8749     8779      +30     
+ Partials     2037     2036       -1     
Files Changed Coverage Δ
internal/common/common_unitest_db.go 18.14% <100.00%> (ø)

... and 15 files with indirect coverage changes

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliorerz, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2585693 and 2 for PR HEAD 8888a5e in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 59ea056 and 1 for PR HEAD 8888a5e in total

@eliorerz
Copy link
Contributor Author

/override ci/prow/edge-e2e-metal-assisted

@openshift-ci
Copy link

openshift-ci bot commented Aug 13, 2023

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-metal-assisted

In response to this:

/override ci/prow/edge-e2e-metal-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 13, 2023

@eliorerz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ead6675 into openshift:master Aug 13, 2023
14 checks passed
@eliorerz eliorerz deleted the NO-ISSUE_Extend_waiting_time_to_test_DB_container_to_be_ready branch August 13, 2023 13:12
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants