MGMT-14881 - return a valid error when no disks has been found

[eifrach]

fix bug where host has failed validation when disk not been found.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[eifrach]

/cc @avishayt
/cc @eliorerz

[codecov]

Codecov Report

Merging #5430 (33e96ba) into master (f5c60d3) will decrease coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is 33.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5430      +/-   ##
==========================================
- Coverage   67.77%   67.75%   -0.03%     
==========================================
  Files         230      230              
  Lines       33553    33560       +7     
==========================================
- Hits        22741    22739       -2     
- Misses       8776     8780       +4     
- Partials     2036     2041       +5     

Files Changed	Coverage Δ
internal/host/validator.go	81.95% <33.33%> (-0.28%)	⬇️

... and 1 file with indirect coverage changes

[eifrach]

/test edge-e2e-metal-assisted

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 7ebd8dc and 2 for PR HEAD 1c246e6 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1b82a8e and 1 for PR HEAD 1c246e6 in total

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, avishayt, eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriengentil,avishayt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ba04805 and 2 for PR HEAD 33e96ba in total

[eifrach]

/retest-required

[openshift-ci]

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.