Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BMH annotation keys to docs #5444

Merged
merged 1 commit into from Aug 25, 2023
Merged

Add BMH annotation keys to docs #5444

merged 1 commit into from Aug 25, 2023

Conversation

carbonin
Copy link
Member

Previously we said which fields could be set using annotations, but didn't document the annotation keys

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see [CONTRIBUTING] guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@carbonin
Add BMH annotation keys to docs
45b2a23 
Previously we said which fields could be set using annotations, but
didn't document the annotation keys
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@openshift-ci openshift-ci bot requested review from danmanor and tsorya August 25, 2023 16:03
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2023

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

omertuc
omertuc reviewed Aug 25, 2023
View reviewed changes
docs/hive-integration/README.md
@@ -160,10 +160,17 @@ In case that the Bare Metal Operator is installed, the Baremetal Agent Controlle

- Find the right pairs of BMH/Agent using their MAC addresses
- Set the Image.URL in the BMH copying it from the InfraEnv's status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even still true since converged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(unrelated to PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but there's a specific section for converged.

@omertuc
Copy link
Contributor

omertuc commented Aug 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 30f738a into openshift:master Aug 25, 2023
6 checks passed
@carbonin carbonin deleted the add_bmh_annotations_to_docs branch August 25, 2023 17:28
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
@carbonin @CrystalChun
Add BMH annotation keys to docs (openshift#5444)
82fdde8 
Previously we said which fields could be set using annotations, but
didn't document the annotation keys
CrystalChun pushed a commit to CrystalChun/assisted-service that referenced this pull request Aug 25, 2023
@carbonin @CrystalChun
Add BMH annotation keys to docs (openshift#5444)
8a20de6 
Previously we said which fields could be set using annotations, but
didn't document the annotation keys
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
@carbonin @danielerez
Add BMH annotation keys to docs (openshift#5444)
4b55f71 
Previously we said which fields could be set using annotations, but
didn't document the annotation keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc omertuc left review comments

@danmanor danmanor Awaiting requested review from danmanor

@tsorya tsorya Awaiting requested review from tsorya

Assignees

@omertuc omertuc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carbonin @omertuc @openshift-merge-robot