Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15100: Remove unused feature-support-levels API endpoint #5450

Conversation

eliorerz
Copy link
Contributor

After deprecating the old API and make sure UI is no longer use it - remove the following endpoint and definitions:

/v2/feature-support-levels 

definitions:
  feature-support-levels:
  feature-support-level:
   

List all the issues related to this PR

  • New Feature
  • Remove Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @avishayt @gamli75

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 30, 2023

@eliorerz: This pull request references MGMT-15100 which is a valid jira issue.

In response to this:

After deprecating the old API and make sure UI is no longer use it - remove the following endpoint and definitions:

/v2/feature-support-levels 

definitions:
 feature-support-levels:
 feature-support-level:
  

List all the issues related to this PR

  • New Feature
  • Remove Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

/cc @avishayt @gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2023
@openshift-ci openshift-ci bot added api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@ammont82: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, avishayt, eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #5450 (58b635b) into master (290cea4) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5450   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files         230      229    -1     
  Lines       33562    33557    -5     
=======================================
- Hits        22746    22744    -2     
+ Misses       8778     8775    -3     
  Partials     2038     2038           
Files Changed Coverage Δ
internal/bminventory/inventory_v2_handlers.go 55.44% <ø> (+0.27%) ⬆️

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 290cea4 and 2 for PR HEAD 58b635b in total

@eliorerz
Copy link
Contributor Author

/override ci/prow/edge-e2e-metal-assisted

@eliorerz
Copy link
Contributor Author

/override ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes
/override ci/prow/e2e-agent-compact-ipv4

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-metal-assisted

In response to this:

/override ci/prow/edge-e2e-metal-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/e2e-agent-compact-ipv4, ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes
/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

@eliorerz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6573b5d into openshift:master Aug 30, 2023
16 checks passed
@eliorerz eliorerz deleted the MGMT-15100_Remove_unused_feature-support-levels_API_endpoint branch August 31, 2023 08:51
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants