Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15732: Add extra flag var for hypershift install #5469

Merged

Conversation

CrystalChun
Copy link
Contributor

https://issues.redhat.com/browse/MGMT-15732
Hypershift install command can change or require
additional flags such as in this issue. This adds the variable in case we need to pass such flags in the future CI tests.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

https://issues.redhat.com/browse/MGMT-15732
Hypershift install command can change or require
additional flags such as in this issue. This adds the
variable in case we need to pass such flags in the
future CI tests.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 7, 2023

@CrystalChun: This pull request references MGMT-15732 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/MGMT-15732
Hypershift install command can change or require
additional flags such as in this issue. This adds the variable in case we need to pass such flags in the future CI tests.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #5469 (739d5f3) into master (cde79f9) will decrease coverage by 0.03%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5469      +/-   ##
==========================================
- Coverage   67.66%   67.64%   -0.03%     
==========================================
  Files         232      232              
  Lines       33974    34651     +677     
==========================================
+ Hits        22990    23440     +450     
- Misses       8938     9139     +201     
- Partials     2046     2072      +26     

see 8 files with indirect coverage changes

@CrystalChun
Copy link
Contributor Author

/retest

@filanov
Copy link
Contributor

filanov commented Sep 13, 2023

/assign @avishayt

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CrystalChun,avishayt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6f08792 and 2 for PR HEAD 739d5f3 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 64bc1c7 and 1 for PR HEAD 739d5f3 in total

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@CrystalChun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-ai-operator-ztp-capi 739d5f3 link false /test edge-e2e-ai-operator-ztp-capi
ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes 739d5f3 link false /test edge-e2e-ai-operator-ztp-hypershift-zero-nodes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9fcb58a and 0 for PR HEAD 739d5f3 in total

@openshift-merge-robot openshift-merge-robot merged commit 12ca0a4 into openshift:master Sep 15, 2023
16 of 18 checks passed
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
https://issues.redhat.com/browse/MGMT-15732
Hypershift install command can change or require
additional flags such as in this issue. This adds the
variable in case we need to pass such flags in the
future CI tests.
@CrystalChun CrystalChun deleted the add-webhook-flag branch January 29, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants