MGMT-15653: Fix DNS regex validation

[CrystalChun]

https://issues.redhat.com/browse/MGMT-15653
The previous DNS regex validation allowed domains
ending in a period '.' which is incorrect. It also did not allow base domains that had more than one
character before the dash. This fixes the domain
validation regex to ensure the issues mentioned
are fixed and adds a check for wildcard domains.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @gamli75 @filanov

[openshift-ci-robot]

@CrystalChun: This pull request references MGMT-15653 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/MGMT-15653
The previous DNS regex validation allowed domains
ending in a period '.' which is incorrect. It also did not allow base domains that had more than one
character before the dash. This fixes the domain
validation regex to ensure the issues mentioned
are fixed and adds a check for wildcard domains.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

/cc @gamli75 @filanov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5482 (38135e3) into master (7e71500) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5482      +/-   ##
==========================================
- Coverage   67.65%   67.64%   -0.01%     
==========================================
  Files         232      232              
  Lines       33988    33993       +5     
==========================================
+ Hits        22994    22996       +2     
- Misses       8948     8950       +2     
- Partials     2046     2047       +1     

Files Changed	Coverage Δ
pkg/validations/validations.go	89.42% <62.50%> (-2.50%)	⬇️

[gamli75]

/test edge-e2e-metal-assisted

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CrystalChun,gamli75]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.