[release-ocm-2.8] MGMT-14830: Enable TechPreviewNoUpgrade when platform is external #5485
Conversation
External platform will only be available behind the `TechPreviewNoUpgrade` feature set. This change enables it automatically when an external platform is selected (e.g.: oci).
|
@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-14830](https://issues.redhat.com//browse/MGMT-14830) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@openshift-ci-robot: This pull request references MGMT-14830 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/S
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| @@ -15,6 +16,9 @@ func (p externalProvider) AddPlatformToInstallConfig(cfg *installcfg.InstallerCo | |||
| None: &installcfg.PlatformNone{}, | |||
| } | |||
|
|
|||
| // Enable feature set "TechPreviewNoUpgrade" in order to access External platform feature | |||
There was a problem hiding this comment.
@filanov This code does not exist in the master code, see: https://github.com/openshift/assisted-service/blob/master/internal/provider/external/installConfig.go
There was a problem hiding this comment.
good catch, this is why i put a hold on the PR.
@adriengentil can you please open a manual PR for this in 2.8?
There was a problem hiding this comment.
I think we can merge this one, and cherry-pick #5381 afterwards.
This code for the oci platform is outdated.
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, gamli75, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit ad21c9e
into
openshift:release-ocm-2.8
This is an automated cherry-pick of #5279
/assign filanov