Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.8] MGMT-15034: MGMT-15047: use installer to deploy on external platform #5490

Conversation

adriengentil
Copy link
Contributor

OCI implementation in 2.8 is outdated, this PR back-ports #5312 and #5381

…enshift#5312)

Patch directly the Infrastructure CR from PostCreateManifestsHook
function which makes it easier to test.

This part of the code is a workaround until the openshift installer
supports external platform.
)

Use the installer to deploy the external platform, and cleanup the
previous hack.
Remove the feature set as the external platform is now stable.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023

@adriengentil: This pull request references MGMT-15034 which is a valid jira issue.

In response to this:

OCI implementation in 2.8 is outdated, this PR back-ports #5312 and #5381

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2023
@adriengentil
Copy link
Contributor Author

/cc @gamli75

@openshift-ci openshift-ci bot requested a review from gamli75 September 14, 2023 08:55
@adriengentil
Copy link
Contributor Author

/test all

@adriengentil
Copy link
Contributor Author

/refresh

@adriengentil
Copy link
Contributor Author

/override ci/prow/e2e-agent-compact-ipv4 ci/prow/edge-assisted-operator-catalog-publish-verify ci/prow/edge-ci-index ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-ai-operator-ztp-3masters ci/prow/edge-e2e-ai-operator-ztp-capi ci/prow/edge-e2e-ai-operator-ztp-disconnected ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes ci/prow/edge-e2e-metal-assisted ci/prow/edge-e2e-nutanix-assisted ci/prow/edge-e2e-oci-assisted ci/prow/edge-e2e-vsphere-assisted ci/prow/edge-images ci/prow/edge-lint ci/prow/edge-subsystem-aws ci/prow/edge-subsystem-kubeapi-aws ci/prow/edge-unit-test ci/prow/edge-verify-generated-code

overriding all edge jobs as I opened this pr against master by mistake

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@adriengentil: adriengentil unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

In response to this:

/override ci/prow/e2e-agent-compact-ipv4 ci/prow/edge-assisted-operator-catalog-publish-verify ci/prow/edge-ci-index ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-ai-operator-ztp-3masters ci/prow/edge-e2e-ai-operator-ztp-capi ci/prow/edge-e2e-ai-operator-ztp-disconnected ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes ci/prow/edge-e2e-metal-assisted ci/prow/edge-e2e-nutanix-assisted ci/prow/edge-e2e-oci-assisted ci/prow/edge-e2e-vsphere-assisted ci/prow/edge-images ci/prow/edge-lint ci/prow/edge-subsystem-aws ci/prow/edge-subsystem-kubeapi-aws ci/prow/edge-unit-test ci/prow/edge-verify-generated-code

overriding all edge jobs as I opened this pr against master by mistake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gamli75
Copy link
Contributor

gamli75 commented Sep 14, 2023

/override ci/prow/e2e-agent-compact-ipv4 ci/prow/edge-assisted-operator-catalog-publish-verify ci/prow/edge-ci-index ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-ai-operator-ztp-3masters ci/prow/edge-e2e-ai-operator-ztp-capi ci/prow/edge-e2e-ai-operator-ztp-disconnected ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes ci/prow/edge-e2e-metal-assisted ci/prow/edge-e2e-nutanix-assisted ci/prow/edge-e2e-oci-assisted ci/prow/edge-e2e-vsphere-assisted ci/prow/edge-images ci/prow/edge-lint ci/prow/edge-subsystem-aws ci/prow/edge-subsystem-kubeapi-aws ci/prow/edge-unit-test ci/prow/edge-verify-generated-code

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, gamli75, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-agent-compact-ipv4, ci/prow/edge-assisted-operator-catalog-publish-verify, ci/prow/edge-ci-index, ci/prow/edge-e2e-ai-operator-ztp, ci/prow/edge-e2e-ai-operator-ztp-3masters, ci/prow/edge-e2e-ai-operator-ztp-capi, ci/prow/edge-e2e-ai-operator-ztp-disconnected, ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes, ci/prow/edge-e2e-metal-assisted, ci/prow/edge-e2e-nutanix-assisted, ci/prow/edge-e2e-oci-assisted, ci/prow/edge-e2e-vsphere-assisted, ci/prow/edge-images, ci/prow/edge-lint, ci/prow/edge-subsystem-aws, ci/prow/edge-subsystem-kubeapi-aws, ci/prow/edge-unit-test, ci/prow/edge-verify-generated-code

In response to this:

/override ci/prow/e2e-agent-compact-ipv4 ci/prow/edge-assisted-operator-catalog-publish-verify ci/prow/edge-ci-index ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-ai-operator-ztp-3masters ci/prow/edge-e2e-ai-operator-ztp-capi ci/prow/edge-e2e-ai-operator-ztp-disconnected ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes ci/prow/edge-e2e-metal-assisted ci/prow/edge-e2e-nutanix-assisted ci/prow/edge-e2e-oci-assisted ci/prow/edge-e2e-vsphere-assisted ci/prow/edge-images ci/prow/edge-lint ci/prow/edge-subsystem-aws ci/prow/edge-subsystem-kubeapi-aws ci/prow/edge-unit-test ci/prow/edge-verify-generated-code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #5490 (01fec03) into release-ocm-2.8 (07c0737) will decrease coverage by 0.09%.
Report is 1 commits behind head on release-ocm-2.8.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-ocm-2.8    #5490      +/-   ##
===================================================
- Coverage            67.49%   67.41%   -0.09%     
===================================================
  Files                  218      222       +4     
  Lines                32725    32761      +36     
===================================================
- Hits                 22088    22086       -2     
- Misses                8643     8680      +37     
- Partials              1994     1995       +1     
Files Changed Coverage Δ
internal/provider/external/ignition.go 0.00% <ø> (ø)
internal/provider/external/installConfig.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@adriengentil
Copy link
Contributor Author

/test mce-images

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4156577 into openshift:release-ocm-2.8 Sep 14, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants