New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-15732: Fix unbound variable #5493
Conversation
https://issues.redhat.com/browse/MGMT-15732 Variable didn't have a default value, causing tests to exit prematurely due to the potential of this being unset.
@CrystalChun: This pull request references MGMT-15732 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@CrystalChun: This pull request references MGMT-15732 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@CrystalChun: This pull request references MGMT-15732 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@CrystalChun: This pull request references MGMT-15732 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
The hypershift and capi jobs are failing because of the API upgrades (see openshift/cluster-api-provider-agent#82 (comment)) Note another WIP PR is opened to address this |
/retest |
/cc @avishayt |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks good. You can ignore the failing 'zero-nodes' test, it's failing for a few weeks. We can just disable it for now. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5493 +/- ##
=======================================
Coverage 67.65% 67.66%
=======================================
Files 232 232
Lines 34099 34099
=======================================
+ Hits 23070 23072 +2
+ Misses 8969 8968 -1
+ Partials 2060 2059 -1 |
@CrystalChun: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e8b4f41
into
openshift:master
https://issues.redhat.com/browse/MGMT-15732 Variable didn't have a default value, causing tests to exit prematurely due to the potential of this being unset.
https://issues.redhat.com/browse/MGMT-15732
Variable didn't have a default value, causing
tests to exit prematurely due to the potential
of this being unset.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist
/cc @filanov