MGMT-15808: change base image to stream9

[osherdp]

Now that D/S building system fully supports RHEL-9 base images (and allows easy installation of nmstate and other libs that were previously unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S, because installation of nmstate packages (and libvirt-libs) either requires entitlements running on a RHEL node, or maybe alternatively an access to RedHat's internal network (which can be a major problem for development U/S).

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@osherdp: This pull request references MGMT-15808 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Now that D/S building system fully supports RHEL-9 base images (and allows easy installation of nmstate and other libs that were previously unsupported) we can move U/S to stream9 and D/S to ubi9-minimal.

It doesn't seem possible to easily use ubi9-minimal U/S, because installation of nmstate packages (and libvirt-libs) either requires entitlements running on a RHEL node, or maybe alternatively an access to RedHat's internal network (which can be a major problem for development U/S).

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[osherdp]

/test all

[codecov]

Codecov Report

Merging #5497 (d125e1a) into master (2b6e4c4) will increase coverage by 0.22%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5497      +/-   ##
==========================================
+ Coverage   67.64%   67.87%   +0.22%     
==========================================
  Files         232      232              
  Lines       34099    34370     +271     
==========================================
+ Hits        23065    23327     +262     
- Misses       8971     8979       +8     
- Partials     2063     2064       +1     

see 3 files with indirect coverage changes

[osherdp]

/retest

[osherdp]

/hold
synchronizing with D/S changes

/cc @nmagnezi @gamli75 @danmanor @adriengentil

[nmagnezi]

/test e2e-agent-compact-ipv4

[nmagnezi]

/lgtm

[nmagnezi]

Should this also be changed to RHEL9? not sure if it belongs in this PR.

assisted-service/Dockerfile.assisted-service.ocp

Line 5 in e8b4f41

FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.20-openshift-4.14 AS builder

[osherdp]

Should this also be changed to RHEL9? not sure if it belongs in this PR.

assisted-service/Dockerfile.assisted-service.ocp

Line 5 in e8b4f41

FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.20-openshift-4.14 AS builder

I guess it can be done in a followup PR, not sure what's the schedule for ABI for migrating to rhel9

[osherdp]

/override ci/prow/e2e-agent-compact-ipv4
some build clusters are buggy today, this job shouldn't be affected by this change

[osherdp]

/unhold

[openshift-ci]

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/e2e-agent-compact-ipv4

In response to this:

/override ci/prow/e2e-agent-compact-ipv4
some build clusters are buggy today, this job shouldn't be affected by this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, nmagnezi, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriengentil,nmagnezi,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.