NO-ISSUE: fix docker-ce-cli package missing

[osherdp]

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@osherdp: This pull request explicitly references no jira issue.

In response to this:

For some reason it's no longer findable even though it seems like we correctly added the repository:

Complete!
Adding repo from:
https://download.docker.com/linux/centos/docker-ce.repo
CentOS Stream 9 - CRB                            12 MB/s | 5.7 MB
00:00
Last metadata expiration check: 0:00:02 ago on Mon Sep 18 13:28:09 2023.
No match for argument: docker-ce-cli
Error: Unable to find a match: docker-ce-cli

(see
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_assisted-service/5497/pull-ci-openshift-assisted-service-master-edge-images/1703760418561855488)

As we're no longer relying much about docker support (as podman takes preference) we are removing its installation in the assisted-service-build image.

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5499 (b73440a) into master (52ac5d6) will increase coverage by 0.12%.
Report is 10 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5499      +/-   ##
==========================================
+ Coverage   67.64%   67.76%   +0.12%     
==========================================
  Files         232      232              
  Lines       34092    34270     +178     
==========================================
+ Hits        23061    23223     +162     
- Misses       8969     8978       +9     
- Partials     2062     2069       +7     

see 5 files with indirect coverage changes

[javipolo]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: javipolo, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [javipolo,osherdp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[osherdp]

/hold
making sure it's desirable, as the problem only persisted for some amount of time (and it's currently working)

[osherdp]

/cc @rccrdpccl WDYT?
iiuc it's only relevant to the build-in-docker target (or targets that depend on it)

[osherdp]

/retest

[osherdp]

/retest

[osherdp]

/unhold

[rccrdpccl]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 72425e3 and 2 for PR HEAD b73440a in total

[osherdp]

/retest

[openshift-ci]

@osherdp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.