[release-ocm-2.8] MGMT-15559: Change detached annotation condition in non-converged flow #5503
Conversation
https://issues.redhat.com/browse/MGMT-15559 Day 2 workers create BMH and Machine CRs on the spoke cluster when the host starts installing. The non-converged flow initially added the detached annotation for the BMH when the host starts installing too. This causes the BMH to stop being reconciled so the BMH and Machine CRs aren't created in the spoke cluster. This change adds the detached annotation when the host reaches rebooting, joined, or failed instead of installing so that it doesn't conflict with adding the BMH/Machine to the spoke cluster.
|
@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-15559](https://issues.redhat.com//browse/MGMT-15559) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: This pull request references MGMT-15559 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/M
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.8 #5503 +/- ##
===================================================
- Coverage 67.42% 67.40% -0.02%
===================================================
Files 222 222
Lines 32761 32754 -7
===================================================
- Hits 22088 22079 -9
- Misses 8679 8681 +2
Partials 1994 1994
|
|
/cc @ori-amizur @filanov |
openshift-ci
bot
requested review from
filanov and
ori-amizur
and removed request for
eliorerz
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
merged commit 67c30e7
into
openshift:release-ocm-2.8
This is an automated cherry-pick of #5445
/assign CrystalChun