Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15947: Add assisted images service short URL routes #5543

Merged
merged 1 commit into from Oct 10, 2023

Conversation

adriengentil
Copy link
Contributor

Add short URL routes into the ingress object when deploying through the
scripts.

Add short URL routes into the ingress object when deploying through the
scripts.
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@adriengentil
Copy link
Contributor Author

adriengentil commented Oct 10, 2023

/retitle MGMT-15947: Add assisted images service short URL routes

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci openshift-ci bot changed the title WIP: Add assisted images service short URL routes MGMT-15947: Add assisted images service short URL routes Oct 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2023

@adriengentil: This pull request references MGMT-15947 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Add short URL routes into the ingress object when deploying through the
scripts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2023
@adriengentil
Copy link
Contributor Author

/cherry-pick release-ocm-2.9

@openshift-cherrypick-robot

@adriengentil: once the present PR merges, I will cherry-pick it on top of release-ocm-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #5543 (c8e0258) into master (91fcb5b) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5543      +/-   ##
==========================================
+ Coverage   67.66%   67.68%   +0.01%     
==========================================
  Files         232      232              
  Lines       34149    34149              
==========================================
+ Hits        23108    23113       +5     
+ Misses       8980     8976       -4     
+ Partials     2061     2060       -1     

see 2 files with indirect coverage changes

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, gamli75

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,gamli75]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriengentil
Copy link
Contributor Author

/test edge-subsystem-kubeapi-aws

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit cbae70b into openshift:master Oct 10, 2023
13 checks passed
@openshift-cherrypick-robot

@adriengentil: new pull request created: #5545

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
Add short URL routes into the ingress object when deploying through the
scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants