MGMT-15796: set CloudControllerManager to External for OCI #5548
Conversation
The installer indroduces a breaking change in the definition of the external platform through openshift/installer#7581. Previously, the CCM was enabled without a way to disable it, now it will be disabled by default with a way to enable it. This change ensure the CCM is enabled when platform is oci in order to keep the current behaviour.
openshift-ci-robot
added
the
jira/valid-reference
|
@adriengentil: This pull request references MGMT-15796 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
size/S
|
/cc @pawanpinjarkar @zaneb |
|
/test unit-test lint |
|
@adriengentil: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-unit-test edge-lint |
|
/test edge-e2e-oci-assisted |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5548 +/- ##
==========================================
- Coverage 67.69% 67.69% -0.01%
==========================================
Files 232 232
Lines 34149 34150 +1
==========================================
Hits 23118 23118
- Misses 8973 8974 +1
Partials 2058 2058
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The install config was generated properly: ... and it did not fail, so I think we can go ahead with this change without waiting for the back-port. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/override ci/prow/edge-e2e-nutanix-assisted ci/prow/edge-e2e-vsphere-assisted |
|
@adriengentil: Overrode contexts on behalf of adriengentil: ci/prow/edge-e2e-nutanix-assisted, ci/prow/edge-e2e-vsphere-assisted In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/test edge-verify-generated-code |
|
@adriengentil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick cloud_hotfix_releases |
|
@adriengentil: new pull request created: #5563 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Below is description from the cherrypicked PR for referene. MGMT-15796: set CloudControllerManager to External for OCI The installer indroduces a breaking change in the definition of the external platform through openshift/installer#7581. Previously, the CCM was enabled without a way to disable it, now it will be disabled by default with a way to enable it. This change ensure the CCM is enabled when platform is oci in order to keep the current behaviour.
The installer indroduces a breaking change in the definition of the external
platform through openshift/installer#7581. Previously,
the CCM was enabled without a way to disable it, now it will be disabled by
default with a way to enable it.
This change ensure the CCM is enabled when platform is oci in order to keep the
current behaviour.