Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix console output in ZTP jobs #5562

Merged
merged 1 commit into from Oct 17, 2023

Conversation

adriengentil
Copy link
Contributor

#5550 was merged by mistake.

The installer params don't allow --console flags, using --append-karg
instead.

openshift#5550 was merged by mistake.

The installer params don't allow `--console` flags, using `--append-karg`
instead.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2023
@openshift-ci-robot
Copy link

@adriengentil: This pull request explicitly references no jira issue.

In response to this:

#5550 was merged by mistake.

The installer params don't allow --console flags, using --append-karg
instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Contributor Author

/cc @nmagnezi @ori-amizur @gamli75

@ori-amizur
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 17, 2023
@openshift-ci openshift-ci bot requested a review from eliorerz October 17, 2023 08:42
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5562 (cef0a6e) into master (c829a60) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5562   +/-   ##
=======================================
  Coverage   67.68%   67.69%           
=======================================
  Files         232      232           
  Lines       34150    34150           
=======================================
+ Hits        23116    23118    +2     
+ Misses       8975     8974    -1     
+ Partials     2059     2058    -1     

see 1 file with indirect coverage changes

@openshift-ci openshift-ci bot merged commit aa0f8d5 into openshift:master Oct 17, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants