MGMT-15980: added missing Create op to infraenvs Webhook #5569

danielerez · 2023-10-18T09:45:28Z

In order to enable ValidatingWebhook on InfraEnv creation, added 'Create' to operations list.

E.g. the following error should be thrown when an InfraEnv is created with both clusterRef and osImageVersion:

Error from server (BadRequest): error when creating "infraEnv.yaml": admission webhook "infraenvvalidators.admission.agentinstall.openshift.io" denied the request: Either Spec.ClusterRef or Spec.OSImageVersion should be specified (not both).

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

In order to enable ValidatingWebhook on InfraEnv creation, added 'Create' to operations list.

openshift-ci-robot · 2023-10-18T09:45:32Z

openshift-ci · 2023-10-18T09:45:34Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

danielerez · 2023-10-18T09:45:51Z

/test all

codecov · 2023-10-18T09:59:50Z

Codecov Report

Merging #5569 (e3ef092) into master (16d1ed2) will increase coverage by 0.28%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5569      +/-   ##
==========================================
+ Coverage   67.68%   67.96%   +0.28%     
==========================================
  Files         232      232              
  Lines       34158    34609     +451     
==========================================
+ Hits        23120    23523     +403     
- Misses       8977     8993      +16     
- Partials     2061     2093      +32

Files	Coverage Δ
...oller/controllers/agentserviceconfig_controller.go	`85.00% <100.00%> (+0.13%)`	⬆️

... and 3 files with indirect coverage changes

openshift-ci-robot · 2023-10-18T10:52:42Z

@danielerez: This pull request references MGMT-15980 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

In order to enable ValidatingWebhook on InfraEnv creation, added 'Create' to operations list.

E.g. the following error should be thrown when an InfraEnv is created with both clusterRef and osImageVersion:
Error from server (BadRequest): error when creating "infraEnv.yaml": admission webhook "infraenvvalidators.admission.agentinstall.openshift.io" denied the request: Either Spec.ClusterRef or Spec.OSImageVersion should be specified (not both).
List all the issues related to this PR

New Feature

Enhancement

Bug fix

Tests

Documentation

CI/CD

What environments does this code impact?

Automation (CI, tools, etc)

Cloud

Operator Managed Deployments

None

How was this code tested?

assisted-test-infra environment

dev-scripts environment

Reviewer's test appreciated

Waiting for CI to do a full test run

Manual (Elaborate on how it was tested)

No tests needed

Checklist

Title and description added to both, commit and PR.

Relevant issues have been associated (see CONTRIBUTING guide)

This change does not require a documentation update (docstring, docs, README, etc)

Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?

Is there a bug required (and linked) for this change?

Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danielerez · 2023-10-18T11:46:49Z

/override ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes
(job is broken and unused)

openshift-ci · 2023-10-18T11:47:05Z

@danielerez: Overrode contexts on behalf of danielerez: ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes
(job is broken and unused)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danielerez · 2023-10-18T12:56:10Z

/cc @nmagnezi
/cc @filanov

openshift-ci · 2023-10-18T15:26:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danielerez,filanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-10-18T15:40:45Z

/retest-required

Remaining retests: 0 against base HEAD 080505c and 2 for PR HEAD e3ef092 in total

danielerez · 2023-10-18T16:16:24Z

/override ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes
(job is broken and unused)

openshift-ci · 2023-10-18T16:23:30Z

@danielerez: Overrode contexts on behalf of danielerez: ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes

In response to this:

/override ci/prow/edge-e2e-ai-operator-ztp-hypershift-zero-nodes
(job is broken and unused)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-18T17:55:06Z

/retest-required

Remaining retests: 0 against base HEAD afd2b74 and 1 for PR HEAD e3ef092 in total

danielerez · 2023-10-19T10:43:42Z

/retest

openshift-ci-robot · 2023-10-19T13:45:31Z

/retest-required

Remaining retests: 0 against base HEAD 03032a9 and 0 for PR HEAD e3ef092 in total

openshift-ci-robot · 2023-10-19T15:40:17Z

/hold

Revision e3ef092 was retested 3 times: holding

danielerez · 2023-10-19T16:10:37Z

/retest

danielerez · 2023-10-20T07:50:53Z

/retest

danielerez · 2023-10-20T09:58:47Z

/unhold

openshift-ci · 2023-10-20T15:03:10Z

@danielerez: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

danielerez · 2023-10-21T09:26:42Z

/retest

danielerez · 2023-10-22T08:10:35Z

/override ci/prow/e2e-agent-compact-ipv4
(job passed, but the status isn't updated in github)

openshift-ci · 2023-10-22T08:10:50Z

@danielerez: Overrode contexts on behalf of danielerez: ci/prow/e2e-agent-compact-ipv4

In response to this:

/override ci/prow/e2e-agent-compact-ipv4
(job passed, but the status isn't updated in github)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danielerez · 2023-10-22T08:17:59Z

/cherry-pick release-ocm-2.9

openshift-cherrypick-robot · 2023-10-22T08:18:50Z

@danielerez: new pull request created: #5577

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

MGMT-15980: added missing Create op to infraenvs Webhook

e3ef092

In order to enable ValidatingWebhook on InfraEnv creation, added 'Create' to operations list.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023

danielerez marked this pull request as ready for review October 18, 2023 12:56

openshift-ci bot requested review from filanov and nmagnezi October 18, 2023 12:56

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023

openshift-ci bot requested review from jhernand and paul-maidment October 18, 2023 13:02

filanov approved these changes Oct 18, 2023

View reviewed changes

openshift-ci bot assigned filanov Oct 18, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023

openshift-ci bot merged commit 2a123c5 into openshift:master Oct 22, 2023
16 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 22, 2023

[release-ocm-2.9] MGMT-15980: added missing Create op to infraenvs Webhook #5577

Merged

MGMT-15980: added missing Create op to infraenvs Webhook #5569

MGMT-15980: added missing Create op to infraenvs Webhook #5569

Conversation

danielerez commented Oct 18, 2023 • edited

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Oct 18, 2023 • edited by openshift-ci bot

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci bot commented Oct 18, 2023

danielerez commented Oct 18, 2023

codecov bot commented Oct 18, 2023 • edited

Codecov Report

openshift-ci-robot commented Oct 18, 2023 • edited by openshift-ci bot

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

danielerez commented Oct 18, 2023

openshift-ci bot commented Oct 18, 2023

danielerez commented Oct 18, 2023

openshift-ci bot commented Oct 18, 2023

openshift-ci-robot commented Oct 18, 2023

danielerez commented Oct 18, 2023

openshift-ci bot commented Oct 18, 2023

openshift-ci-robot commented Oct 18, 2023

danielerez commented Oct 19, 2023

openshift-ci-robot commented Oct 19, 2023

openshift-ci-robot commented Oct 19, 2023

danielerez commented Oct 19, 2023

danielerez commented Oct 20, 2023

danielerez commented Oct 20, 2023

openshift-ci bot commented Oct 20, 2023

danielerez commented Oct 21, 2023

danielerez commented Oct 22, 2023

openshift-ci bot commented Oct 22, 2023

danielerez commented Oct 22, 2023

openshift-cherrypick-robot commented Oct 22, 2023

danielerez commented Oct 18, 2023 •

edited

openshift-ci-robot commented Oct 18, 2023 •

edited by openshift-ci bot

codecov bot commented Oct 18, 2023 •

edited

openshift-ci-robot commented Oct 18, 2023 •

edited by openshift-ci bot