MGMT-15971: Create ManagedCluster CR so that the hub will show up as "Ready" in MCE

[paul-maidment]

Presently, the locally imported hub cluster will show up in the UI of MCE as a "Disconnected" cluster.
This means that the end user will be unable to perform actions such as adding nodes to the cluster.

This PR addresses this issue by changing the naming, and namespacing of the AgentClusterInstall and ClusterDeployment CR's so that they reference the already existing ManagedCluster

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
  Going to run up MCE UI and make sure that the Hosted Cluster shows up as "Connected" once automatically created
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-15971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Presently, the locally imported hub cluster will show up in the UI of MCE as a "Disconnected" cluster. This means that the end user will be unable to perform actions such as adding nodes to the cluster.

This PR aims to address that by creating the ManagedCluster resource at the same time as the other hub cluster import resources

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
  Going to run up MCE UI and make sure that the Hosted Cluster shows up as "Connected" once automatically created
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Merging #5575 (145ae1e) into master (9e9b328) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5575      +/-   ##
==========================================
+ Coverage   67.73%   67.77%   +0.04%     
==========================================
  Files         234      234              
  Lines       34468    34468              
==========================================
+ Hits        23348    23362      +14     
+ Misses       9041     9033       -8     
+ Partials     2079     2073       -6     

Files	Coverage Δ
pkg/localclusterimport/import_local_cluster.go	84.21% <100.00%> (ø)

... and 2 files with indirect coverage changes

[openshift-ci-robot]

@paul-maidment: This pull request references MGMT-15971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Presently, the locally imported hub cluster will show up in the UI of MCE as a "Disconnected" cluster.
This means that the end user will be unable to perform actions such as adding nodes to the cluster.

This PR addresses this issue by changing the naming, and namespacing of the AgentClusterInstall and ClusterDeployment CR's so that they reference the already existing ManagedCluster

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
  Going to run up MCE UI and make sure that the Hosted Cluster shows up as "Connected" once automatically created
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [avishayt,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202311131732.p0.gfba5931.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.