Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cloud_hotfix_releases] MGMT-16037: fix messaging errors on big clusters #5631

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5628

/assign rccrdpccl

Signed-off-by: Riccardo piccoli <rpiccoli@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 27, 2023

@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-16037](https://issues.redhat.com//browse/MGMT-16037) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #5628

/assign rccrdpccl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 27, 2023

@openshift-ci-robot: This pull request references MGMT-16037 which is a valid jira issue.

In response to this:

@openshift-cherrypick-robot: Could not make automatic cherrypick of [Jira Issue MGMT-16037](https://issues.redhat.com//browse/MGMT-16037) for this PR as the target version is not set for this branch in the jira plugin config. Running refresh:
/jira refresh

In response to this:

This is an automated cherry-pick of #5628

/assign rccrdpccl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #5631 (5d0ea37) into cloud_hotfix_releases (aa0f8d5) will increase coverage by 0.00%.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           cloud_hotfix_releases    #5631   +/-   ##
======================================================
  Coverage                  67.69%   67.69%           
======================================================
  Files                        232      233    +1     
  Lines                      34150    34160   +10     
======================================================
+ Hits                       23118    23125    +7     
- Misses                      8974     8976    +2     
- Partials                    2058     2059    +1     
Files Coverage Δ
internal/bminventory/inventory.go 70.29% <100.00%> (+0.02%) ⬆️
internal/stream/utils.go 100.00% <100.00%> (ø)
internal/usage/manager.go 72.50% <100.00%> (+0.70%) ⬆️
internal/cluster/common.go 76.36% <66.66%> (-0.33%) ⬇️

... and 1 file with indirect coverage changes

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@rccrdpccl
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD aa0f8d5 and 2 for PR HEAD 5d0ea37 in total

@rccrdpccl
Copy link
Contributor

/retest subsystem-aws

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@rccrdpccl: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-metal-assisted-4-10
  • /test e2e-metal-assisted-4-11
  • /test e2e-metal-assisted-4-12
  • /test e2e-metal-assisted-4-9
  • /test e2e-metal-assisted-cnv
  • /test e2e-metal-assisted-day2
  • /test e2e-metal-assisted-ipv4v6
  • /test e2e-metal-assisted-lvm
  • /test e2e-metal-assisted-odf
  • /test e2e-metal-assisted-onprem
  • /test e2e-metal-assisted-single-node
  • /test e2e-metal-assisted-static-ip-suite
  • /test images
  • /test lint
  • /test subsystem-aws
  • /test unit-test
  • /test verify-generated-code

The following commands are available to trigger optional jobs:

  • /test e2e-metal-assisted-4-13

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-day2
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-ipv4v6
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-onprem
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-single-node
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-e2e-metal-assisted-static-ip-suite
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-images
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-lint
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-subsystem-aws
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-unit-test
  • pull-ci-openshift-assisted-service-cloud_hotfix_releases-verify-generated-code

In response to this:

/retest subsystem-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rccrdpccl
Copy link
Contributor

/test subsystem-aws

@gamli75
Copy link
Contributor

gamli75 commented Oct 29, 2023

/retest-required

@rccrdpccl
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 57a0dd0 into openshift:cloud_hotfix_releases Oct 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants