Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Allow the command in wait_for_cmd_amount to receive arguments to pass to the inner function #5668

Merged
merged 1 commit into from Nov 7, 2023
Merged

NO-JIRA: Allow the command in wait_for_cmd_amount to receive arguments to pass to the inner function #5668

merged 1 commit into from Nov 7, 2023

Conversation

ori-amizur
Copy link
Contributor

This was already assumed but it is not the case now

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @paul-maidment

@ori-amizur
NO-JIRA: Allow the command in wait_for_cmd_amount to receive arguments
a6754d0 
This was already assumed but it is not the case now
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 6, 2023
@openshift-ci-robot
Copy link

@ori-amizur: This pull request explicitly references no jira issue.

In response to this:

This was already assumed but it is not the case now

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

/cc @paul-maidment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2023
@ori-amizur
Copy link
Contributor Author

/test edge-e2e-ai-operator-ztp-sno-day2-workers

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited

Codecov Report

Merging #5668 (a6754d0) into master (ea87037) will increase coverage by 0.16%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5668      +/-   ##
==========================================
+ Coverage   67.73%   67.90%   +0.16%     
==========================================
  Files         233      233              
  Lines       34326    34617     +291     
==========================================
+ Hits        23252    23507     +255     
- Misses       9009     9024      +15     
- Partials     2065     2086      +21

see 5 files with indirect coverage changes

@ori-amizur
Copy link
Contributor Author

/retest

@ori-amizur ori-amizur changed the title NO-JIRA: Allow the command in wait_for_cmd_amount to receive arguments NO-JIRA: Allow the command in wait_for_cmd_amount to receive arguments to pass to the inner function Nov 7, 2023
paul-maidment
paul-maidment reviewed Nov 7, 2023
View reviewed changes
deploy/operator/utils.sh
@@ -123,10 +123,10 @@ function wait_for_cmd_amount() {
interval="$2"
cmd="$3"

until [ $(${cmd} | wc -l) -eq ${amount} ]; do
until [ $(${cmd} "${@:4}" | wc -l) -eq ${amount} ]; do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to create a var in a similar fashion to 'cmd'

I.e

arguments = "${@:4}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is multiple arguments, it seems better this way

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@paul-maidment
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@adriengentil
Copy link
Contributor

/test edge-e2e-ai-operator-ztp-node-labels

@adriengentil
Copy link
Contributor

/hold
to prevent the merge before all jobs have been tested

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@ori-amizur
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2023

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e6fc5f3 into openshift:master Nov 7, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-maidment paul-maidment paul-maidment left review comments

Assignees

@paul-maidment paul-maidment

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ori-amizur @openshift-ci-robot @paul-maidment @adriengentil