Add missing scheme to ServiceMonitor

[omertuc]

The commit db30aab attempted to add TLS
to the service monitor but it forgot to change the scheme to https and
this was noticed during QE for the ticket associated with that commit

Solves MGMT-14756

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
  • Ran a hub cluster and checked that servicemonitor was working
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[codecov]

Codecov Report

Merging #5672 (351b67d) into master (8eca4e2) will decrease coverage by 0.01%.
Report is 14 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5672      +/-   ##
==========================================
- Coverage   67.75%   67.75%   -0.01%     
==========================================
  Files         233      234       +1     
  Lines       34368    34469     +101     
==========================================
+ Hits        23286    23354      +68     
- Misses       9013     9039      +26     
- Partials     2069     2076       +7     

Files	Coverage Δ
...oller/controllers/agentserviceconfig_controller.go	84.58% <100.00%> (-0.30%)	⬇️

... and 10 files with indirect coverage changes

[omertuc]

/retest

[omertuc]

/test edge-e2e-ai-operator-ztp-capi

[omertuc]

/test edge-e2e-ai-operator-ztp-capi

[omertuc]

/test edge-e2e-ai-operator-ztp-capi

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [filanov,omertuc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omertuc]

/cherry-pick release-ocm-2.9

[openshift-cherrypick-robot]

@omertuc: once the present PR merges, I will cherry-pick it on top of release-ocm-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@omertuc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-ai-operator-ztp-capi	351b67d	link	false	/test edge-e2e-ai-operator-ztp-capi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@omertuc: new pull request created: #5686

In response to this:

/cherry-pick release-ocm-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.15.0-202311140008.p0.g9933eef.assembly.stream for distgit ose-agent-installer-api-server.
All builds following this will include this PR.